Refs #20648: Change Github workflows trigger to 'review_requested'

Signed-off-by: EduPonz <[email protected]>
eProsima · Mar 25, 2024 · ae1fafd · ae1fafd
1 parent 843a675
commit ae1fafd
Show file tree

Hide file tree

Showing 9 changed files with 7 additions and 98 deletions.
diff --git a/.github/workflows/address-sanitizers.yaml b/.github/workflows/address-sanitizers.yaml
@@ -14,7 +14,7 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
@@ -31,10 +31,6 @@ jobs:
   asan-test:
 
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'no-test') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
@@ -46,15 +42,6 @@ jobs:
         FASTDDS_BRANCH: ${{ github.head_ref || github.event.inputs.fastdds_branch || 'master' }}
 
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0
@@ -150,10 +137,6 @@ jobs:
   asan-discovery-server-test:
 
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'no-test') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
@@ -166,15 +149,6 @@ jobs:
       DEFAULT_DISCOVERY_SERVER_BRANCH: ${{ github.event.inputs.discovery_server_branch || 'master' }}
 
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/documentation-tests.yaml b/.github/workflows/documentation-tests.yaml
@@ -10,7 +10,7 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
@@ -27,25 +27,12 @@ jobs:
   ubuntu-build-and-test-documentation:
     name: Documentation build and test
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
             ) }}
 
     runs-on: ubuntu-22.04
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/mac-ci.yml b/.github/workflows/mac-ci.yml
@@ -26,7 +26,7 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
@@ -39,10 +39,6 @@ concurrency:
 jobs:
   mac-ci:
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
             ) }}

diff --git a/.github/workflows/reusable-mac-ci.yml b/.github/workflows/reusable-mac-ci.yml
@@ -44,15 +44,6 @@ jobs:
         cmake-build-type:
           - 'RelWithDebInfo'
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/reusable-ubuntu-ci.yml b/.github/workflows/reusable-ubuntu-ci.yml
@@ -42,15 +42,6 @@ jobs:
         cmake-build-type:
           - 'RelWithDebInfo'
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/reusable-windows-ci.yml b/.github/workflows/reusable-windows-ci.yml
@@ -41,15 +41,6 @@ jobs:
           - 'v141'
           - 'v142'
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/thread-sanitizer.yaml b/.github/workflows/thread-sanitizer.yaml
@@ -17,7 +17,7 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
@@ -36,10 +36,6 @@ jobs:
     name: Sanitizer Evaluation
 
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'no-test') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
@@ -56,15 +52,6 @@ jobs:
         CXX: g++-12
 
     steps:
-      - name: Remove run-ci label if PR
-        if: ${{ github.event_name == 'pull_request' }}
-        uses: eProsima/eProsima-CI/external/remove_labels@v0
-        with:
-          labels: run-ci
-          number: ${{ github.event.number }}
-          repo: eProsima/Fast-DDS
-          fail_on_error: 'false'
-
       - name: Add ci-pending label if PR
         if: ${{ github.event_name == 'pull_request' }}
         uses: eProsima/eProsima-CI/external/add_labels@v0

diff --git a/.github/workflows/ubuntu-ci.yml b/.github/workflows/ubuntu-ci.yml
@@ -26,14 +26,14 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
       - '!**/CMakeLists.txt'
 
 concurrency:
-  group: ${{ github.workflow }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 
 jobs:
@@ -46,10 +46,6 @@ jobs:
           - 'ubuntu-22.04'
 
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
             ) }}

diff --git a/.github/workflows/windows-ci.yml b/.github/workflows/windows-ci.yml
@@ -26,7 +26,7 @@ on:
 
   pull_request:
     types:
-      - labeled
+      - review_requested
     paths-ignore:
       - '**.md'
       - '**.txt'
@@ -39,10 +39,6 @@ concurrency:
 jobs:
   windows-ci:
     if: ${{ (
-              (github.event_name == 'workflow_dispatch') ||
-              contains(github.event.pull_request.labels.*.name, 'run-ci')
-            ) &&
-            (
               !contains(github.event.pull_request.labels.*.name, 'skip-ci') &&
               !contains(github.event.pull_request.labels.*.name, 'conflicts')
             ) }}