Refs #20165. Apply suggestions

Signed-off-by: Ricardo González Moreno <[email protected]>
eProsima · Sep 24, 2024 · b548118 · b548118
1 parent 5b5eaeb
commit b548118
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp b/src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp
@@ -218,6 +218,7 @@ void TypeLookupReplyListener::check_get_types_reply(
     }
     else
     {
+        typelookup_manager_->notify_callbacks(RETCODE_NO_DATA, type_id);
         EPROSIMA_LOG_WARNING(TYPELOOKUP_SERVICE_REPLY_LISTENER,
                 "Received reply with no types.");
         register_result = RETCODE_ERROR;

diff --git a/test/unittest/dds/xtypes/type_lookup_service/TypeLookupServiceTests.cpp b/test/unittest/dds/xtypes/type_lookup_service/TypeLookupServiceTests.cpp
@@ -618,6 +618,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_wrong_replyid)
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);
 
     TypeLookup_Reply reply;
+    reply.header().relatedRequestId(valid_sampleidentity());
     reply.return_value()._default();
     ReplyWithServerGUID reply_with_guid;
     reply_with_guid.reply = reply;
@@ -632,7 +633,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_wrong_replyid)
 TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_getTypes_empty)
 {
     MockLogConsumer* log_consumer =
-            setup_expect_log_msg("TYPELOOKUP_SERVICE_REPLY_LISTENER", "Reply no contains any type.");
+            setup_expect_log_msg("TYPELOOKUP_SERVICE_REPLY_LISTENER", "Received reply with no types.");
 
     TypeIdentfierWithSize tidws;
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);
@@ -852,7 +853,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupRequestListener_getTypes_empty)
 {
     MockLogConsumer* log_consumer =
             setup_expect_log_msg("TYPELOOKUP_SERVICE_REQUEST_LISTENER",
-                    "Request no contains any type identifier.");
+                    "Received request with no type identifiers.");
 
     TypeIdentfierWithSize tidws;
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);