-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17138] Refactor of DynamicTypes #3392
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelBarro
force-pushed
the
feature/xtypes
branch
from
March 21, 2023 11:53
df5de90
to
33346d9
Compare
@richiprosima Please test this for me |
MiguelBarro
force-pushed
the
feature/xtypes
branch
from
March 21, 2023 15:17
33346d9
to
634ee24
Compare
@richiprosima Please test this for me |
1 similar comment
@richiprosima Please test this for me |
MiguelBarro
force-pushed
the
feature/xtypes
branch
2 times, most recently
from
March 23, 2023 22:23
425380f
to
36934ea
Compare
1 task
@richiprosima Please test this for me |
MiguelBarro
force-pushed
the
feature/xtypes
branch
2 times, most recently
from
March 25, 2023 23:18
0a5b1a4
to
6b2ac10
Compare
@richiprosima Please test this for me |
MiguelBarro
force-pushed
the
feature/xtypes
branch
6 times, most recently
from
March 30, 2023 15:17
cb4f0d5
to
1ac8ed9
Compare
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
MiguelBarro
force-pushed
the
feature/xtypes
branch
2 times, most recently
from
July 20, 2023 08:41
02ee437
to
f163eda
Compare
Signed-off-by: Miguel Barro <[email protected]>
MiguelBarro
force-pushed
the
feature/xtypes
branch
from
July 20, 2023 08:43
f163eda
to
ee94c25
Compare
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
This reverts commit 40c42c9.
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
richiware
force-pushed
the
feature/xtypes1.3
branch
from
November 28, 2023 10:17
0e82cdf
to
d45d7b3
Compare
JLBuenoLopez
force-pushed
the
feature/xtypes1.3
branch
from
January 9, 2024 13:26
b4f26bc
to
92ebc68
Compare
JLBuenoLopez
force-pushed
the
feature/xtypes1.3
branch
from
January 25, 2024 15:08
89f04cd
to
8509399
Compare
JLBuenoLopez
force-pushed
the
feature/xtypes1.3
branch
from
February 15, 2024 09:54
7b4c6fb
to
bf49f7b
Compare
Closed in favor of #4190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several works aimed to fulfill latest omg standard and fix issues.
Among them:
DynamicTypeBuildeFactory
andDynamicTypeBuilder
) to enforcedshared_ptr
use and allocate in a single heap block.TypeDescriptor
,DynamicTypeBuilder
andDynamicType
) to enforceTypeDescriptor
as state holder and remove redundant references and members. Avoid API implementation duplicates.friend
class device to a necessary basis and enforce class independence through APIs. This paves way toDynamicData
class refactorization.DynamicType
in order to:DynamicData
internals.DynamicTypes
.Documentation update: eProsima/Fast-DDS-docs#479
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist