Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17138] Refactor of DynamicTypes #3392

Closed
wants to merge 140 commits into from
Closed

Conversation

MiguelBarro
Copy link
Contributor

@MiguelBarro MiguelBarro commented Mar 21, 2023

Description

Several works aimed to fulfill latest omg standard and fix issues.
Among them:

  • Update the factories (DynamicTypeBuildeFactory and DynamicTypeBuilder) to enforced shared_ptr use and allocate in a single heap block.
  • Reorder class hierarchy (TypeDescriptor, DynamicTypeBuilder and DynamicType) to enforce TypeDescriptor as state holder and remove redundant references and members. Avoid API implementation duplicates.
  • Reduce the friend class device to a necessary basis and enforce class independence through APIs. This paves way to DynamicData class refactorization.
  • Comprehensive annotation support.
  • Enforce the use of static objects for primitive types as standard advices.
  • Move serialization implementation to DynamicType in order to:
    • Make serializatio independent from DynamicData internals.
    • Double check by asserting each member type is the expected one.
  • New test for primitives and complex aggregation types.
  • Tests fixes and enhanced gtest support for comparisons via proper traces of the DynamicTypes.

Documentation update: eProsima/Fast-DDS-docs#479

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

1 similar comment
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

2 similar comments
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

@MiguelBarro MiguelBarro force-pushed the feature/xtypes branch 2 times, most recently from 0a5b1a4 to 6b2ac10 Compare March 25, 2023 23:18
@MiguelBarro
Copy link
Contributor Author

@richiprosima Please test this for me

@MiguelBarro MiguelBarro force-pushed the feature/xtypes branch 6 times, most recently from cb4f0d5 to 1ac8ed9 Compare March 30, 2023 15:17
Miguel Barro added 4 commits July 19, 2023 15:32
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
Signed-off-by: Miguel Barro <[email protected]>
@MiguelBarro MiguelBarro force-pushed the feature/xtypes branch 2 times, most recently from 02ee437 to f163eda Compare July 20, 2023 08:41
Signed-off-by: Miguel Barro <[email protected]>
@EduPonz
Copy link

EduPonz commented Feb 26, 2024

Closed in favor of #4190

@EduPonz EduPonz closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment