Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18503] Use eProsima-CI external actions for mirror workflow [WIP] #3503

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented May 9, 2023

Description

This PR depends on eProsima/eProsima-CI#25. Once this PR is merged and released, the branch of the create PR action must be updated previous to merging.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [N/A] The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [N/A] Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez changed the title [18503] Use eProsima-CI external actions for mirror workflow [WIP [18503] Use eProsima-CI external actions for mirror workflow [WIP] May 9, 2023
@JLBuenoLopez JLBuenoLopez added the skip-ci Automatically pass CI label May 9, 2023
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JLBuenoLopez
Copy link
Contributor Author

@JesusPoderoso this PR requires a release in eProsima-CI repository. The version is pointing to, v0.4, does not exist yet. Also, it has the skip-ci label because the CI is not affected by the changes in the PR.

@JLBuenoLopez JLBuenoLopez modified the milestones: v2.10.2, v2.11.0, v2.11.1 Jun 12, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.11.1, v2.11.2 Jul 6, 2023
@MiguelCompany MiguelCompany modified the milestones: v2.11.2, v2.12.0 Aug 7, 2023
@JLBuenoLopez JLBuenoLopez force-pushed the hotfix/use-eprosima-ci-mirror-workflow branch from 02c3d68 to 9f4083d Compare September 18, 2023 10:50
@JLBuenoLopez
Copy link
Contributor Author

I have rebased this PR and updated the version of the action to v0 to use always the latest minor (so the mirror action can be upgraded if a new version of the external action is released).

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@JLBuenoLopez JLBuenoLopez merged commit ad49587 into master Sep 18, 2023
7 checks passed
@JLBuenoLopez JLBuenoLopez deleted the hotfix/use-eprosima-ci-mirror-workflow branch September 18, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants