[20242] TypeLookup listeners implementation #4240

adriancampo · 2024-01-12T12:14:14Z

Description

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupRequestListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

adriancampo · 2024-01-21T16:18:01Z

@richiprosima please test this

adriancampo · 2024-01-22T15:55:16Z

@richiprosima please test this

JLBuenoLopez

Partial review. TypeLookupManager and TypeLookupReplyListener classes pending to be reviewed.

include/fastdds/dds/domain/DomainParticipantListener.hpp

include/fastdds/dds/domain/qos/DomainParticipantQos.hpp

include/fastdds/rtps/attributes/RTPSParticipantAttributes.h

include/fastdds/rtps/builtin/discovery/endpoint/EDP.h

include/fastrtps/xmlparser/XMLParserCommon.h

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupRequestListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupManager.hpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupManager.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

JLBuenoLopez · 2024-04-08T07:13:16Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-04-09T07:37:14Z

The following Doxygen typo would be nice to fix in order for the documentation tests to pass:

Modifies instead of Mofifies.

Now we works successfully against OpenDDS 3.27 Signed-off-by: Ricardo González Moreno <[email protected]>

Signed-off-by: Ricardo González Moreno <[email protected]>

JLBuenoLopez · 2024-04-09T10:07:54Z

@richiprosima please test_3 this

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-09T10:28:54Z

Manual Documentation job: SUCCESS
Manual Discovery Server job: SUCCESS

fastdds.repos

test/unittest/dds/xtypes/type_representation/TypeObjectUtilsTests.cpp

Signed-off-by: Ricardo González <[email protected]>

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-10T09:12:38Z

@richiprosima please test_3 this

* Refs #20157: Implemented async_get_type replies. Signed-off-by: adriancampo <[email protected]> * Refs #20157: Changeds to instance_name. Signed-off-by: adriancampo <[email protected]> * Refs #20157: Changes to check_type_identifier_received Signed-off-by: adriancampo <[email protected]> * Refs #20157: Added continuation point checks. Signed-off-by: adriancampo <[email protected]> * Refs #20157: Removed old function Signed-off-by: adriancampo <[email protected]> * Refs #20160: Implemented async_get_type request listener. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added continuation point management Signed-off-by: adriancampo <[email protected]> * Refs #20160: Renames and comments improvements Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fixed deadlock, renamed discovery methods. Applied suggestions. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Small fix in reply error check. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Created get_complementary_type_identifier method. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added valid_matching check for TypeInformation. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added send and receive error logs. Added missing continuation_point reply management Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added check for requests with no TypeIdentifiers and small fixes. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added listener classes to handle change acks Signed-off-by: adriancampo <[email protected]> * Refs #20160: Restored minimal_from_complete_type_identifier method from TypeObjectRegistry Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fixes for TypeInformation serializer Signed-off-by: adriancampo <[email protected]> * Refs #20160: Added typelookup_service_threads to XMLParser Signed-off-by: adriancampo <[email protected]> * Refs #20160. Remove old function Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20160. Fix Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20160: Fixes for TypeLookupManager destruction with pending callbacks. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Changes for instance_names to use the full GUID. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Applied suggestions. Removed overloaded discovery methods. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Changes for xtypes doc. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fix for LOG macro. Remove consistency check from register_type_object(from TypeLookupManager). Signed-off-by: adriancampo <[email protected]> * Refs #20160: Applied suggestions. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Removed obsolete check. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fixed DS tests and warnings. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fixes after rebase. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Windows warning. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Applied suggestions. Signed-off-by: adriancampo <[email protected]> * Refs #20160: Fixed tests. Signed-off-by: adriancampo <[email protected]> * Refs #20242. Update unsupported_type_info tests. Now we works successfully against OpenDDS 3.27 Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20242. Apply suggestion Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20242. Fix log thread being killed in windows on unit test Signed-off-by: Ricardo González <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> Signed-off-by: Ricardo González Moreno <[email protected]> Signed-off-by: Ricardo González <[email protected]> Co-authored-by: Ricardo González Moreno <[email protected]>

adriancampo added the no-test Skip CI tests if PR marked with this label label Jan 12, 2024

adriancampo marked this pull request as ready for review January 12, 2024 12:16

adriancampo requested a review from JLBuenoLopez January 12, 2024 12:17

JLBuenoLopez suggested changes Jan 16, 2024

View reviewed changes

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from f5f5abc to 52fc9f8 Compare January 19, 2024 18:33

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 2 times, most recently from fde5978 to 29681bc Compare January 22, 2024 15:46

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 22, 2024 15:47

adriancampo changed the base branch from feature/type-object-integration to feature/xtypes1.3 January 22, 2024 15:48

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 22, 2024 15:49

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 9538ccd to 13eb216 Compare January 23, 2024 07:02

adriancampo changed the base branch from feature/type-object-integration to feature/xtypes1.3 January 23, 2024 07:02

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 13eb216 to 2e3caf5 Compare January 23, 2024 08:13

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 23, 2024 08:14

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from 38ebcb1 to dd105e0 Compare January 23, 2024 11:11

JLBuenoLopez force-pushed the feature/type-object-integration branch from ec6de74 to 1186bad Compare January 25, 2024 15:31

Base automatically changed from feature/type-object-integration to feature/xtypes1.3 January 29, 2024 06:56

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from 27df183 to 918454a Compare February 1, 2024 20:05

JLBuenoLopez suggested changes Feb 6, 2024

View reviewed changes

JLBuenoLopez suggested changes Feb 12, 2024

View reviewed changes

JLBuenoLopez force-pushed the feature/xtypes1.3 branch from 7b4c6fb to bf49f7b Compare February 15, 2024 09:54

EduPonz added this to the v3.0.0 milestone Feb 21, 2024

EduPonz previously requested changes Feb 22, 2024

View reviewed changes

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp Outdated Show resolved Hide resolved

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from de0d0e3 to 49cf957 Compare February 22, 2024 19:36

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 2 times, most recently from 4e6bea8 to 27a861e Compare April 9, 2024 07:07

JLBuenoLopez mentioned this pull request Apr 9, 2024

[20242] Update discovery callbacks eProsima/Discovery-Server#75

Merged

richiware force-pushed the feature/typelookup-listeners-implementation branch from 2510674 to 7a602df Compare April 9, 2024 09:59

Refs #20242. Update unsupported_type_info tests.

b0e2e65

Now we works successfully against OpenDDS 3.27 Signed-off-by: Ricardo González Moreno <[email protected]>

richiware force-pushed the feature/typelookup-listeners-implementation branch from 7a602df to b0e2e65 Compare April 9, 2024 10:00

Refs #20242. Apply suggestion

feea1ec

Signed-off-by: Ricardo González Moreno <[email protected]>

JLBuenoLopez requested review from JLBuenoLopez and removed request for JLBuenoLopez April 9, 2024 10:07

JLBuenoLopez approved these changes Apr 9, 2024

View reviewed changes

JLBuenoLopez reviewed Apr 10, 2024

View reviewed changes

fastdds.repos Outdated Show resolved Hide resolved

test/unittest/dds/xtypes/type_representation/TypeObjectUtilsTests.cpp Show resolved Hide resolved

Refs #20242. Fix log thread being killed in windows on unit test

5ae348a

Signed-off-by: Ricardo González <[email protected]>

richiware force-pushed the feature/typelookup-listeners-implementation branch from 1e13843 to 5ae348a Compare April 10, 2024 09:09

JLBuenoLopez approved these changes Apr 10, 2024

View reviewed changes

JLBuenoLopez self-requested a review April 10, 2024 09:12

richiware merged commit fb8e560 into 3.0.x-devel Apr 10, 2024
11 of 14 checks passed

richiware deleted the feature/typelookup-listeners-implementation branch April 10, 2024 14:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20242] TypeLookup listeners implementation #4240

[20242] TypeLookup listeners implementation #4240

adriancampo commented Jan 12, 2024 •

edited by JLBuenoLopez

Loading

adriancampo commented Jan 21, 2024

adriancampo commented Jan 22, 2024

JLBuenoLopez left a comment

JLBuenoLopez commented Apr 8, 2024

JLBuenoLopez commented Apr 9, 2024

JLBuenoLopez commented Apr 9, 2024

JLBuenoLopez left a comment

JLBuenoLopez commented Apr 9, 2024 •

edited

Loading

JLBuenoLopez left a comment

JLBuenoLopez commented Apr 10, 2024

[20242] TypeLookup listeners implementation #4240

[20242] TypeLookup listeners implementation #4240

Conversation

adriancampo commented Jan 12, 2024 • edited by JLBuenoLopez Loading

Description

Contributor Checklist

Reviewer Checklist

adriancampo commented Jan 21, 2024

adriancampo commented Jan 22, 2024

JLBuenoLopez left a comment

Choose a reason for hiding this comment

JLBuenoLopez commented Apr 8, 2024

JLBuenoLopez commented Apr 9, 2024

JLBuenoLopez commented Apr 9, 2024

JLBuenoLopez left a comment

Choose a reason for hiding this comment

JLBuenoLopez commented Apr 9, 2024 • edited Loading

JLBuenoLopez left a comment

Choose a reason for hiding this comment

JLBuenoLopez commented Apr 10, 2024

adriancampo commented Jan 12, 2024 •

edited by JLBuenoLopez

Loading

JLBuenoLopez commented Apr 9, 2024 •

edited

Loading