-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20438] LARGE_DATA Participants logic with same listening ports (backport #4396) #4434
Conversation
@cferreiragonz would you mind taking a look at the conflicts ? |
99c6817
to
0fb138c
Compare
21be33e
to
c077af7
Compare
@cferreiragonz would you mind looking at the conflicts here ? Next one in the loop ! |
* Refs #20438: Add unittest to validate interfaces check Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Add support to same listening_port and different IP address Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Fix Windows build Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Add Ipv6 addresses support Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Remove repeated addition of listener port (added by default) Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Apply suggestions Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Apply suggestions: ipv6 Signed-off-by: cferreiragonz <[email protected]> * Refs #20438: Fix windows build Signed-off-by: cferreiragonz <[email protected]> --------- Signed-off-by: cferreiragonz <[email protected]> (cherry picked from commit 3ff9180)
Signed-off-by: cferreiragonz <[email protected]>
0fb138c
to
ab52f60
Compare
@richiprosima please test this |
@richiprosima please test windows |
@cferreiragonz do you think that the failed test BlackboxTests_DDS_PIM.TransportTCP.large_data_topology.Transport in the ubuntu github ci is related ? Otherwise, LGTM |
I believe that is unrelated with this PR. I could not reproduce the timeout locally after multiple tries. |
This is an automatic backport of pull request #4396 done by Mergify.
Cherry-pick of 3ff9180 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com