-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20311] Add missing TypeLookup listeners (backport #4335) #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
@irenebm would you mind taking a look at the conflicts ? |
irenebm
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
February 23, 2024 09:01
0cbb4f0
to
19e12c9
Compare
EduPonz
added
ci-pending
PR which CI is running
and removed
conflicts
Backport PR wich git cherry pick failed
labels
Feb 24, 2024
@Mergifyio rebase 2.6.x |
✅ Branch has been successfully rebased |
Mario-DL
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
March 7, 2024 07:17
19e12c9
to
02a091b
Compare
@richiprosima please test this |
@Mergifyio rebase 2.6.x |
* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <[email protected]> * Uncrustify Signed-off-by: Irene Bandera <[email protected]> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <[email protected]> * Apply changes Signed-off-by: Irene Bandera <[email protected]> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Irene Bandera <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]>
✅ Branch has been successfully rebased |
Mario-DL
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
April 2, 2024 06:10
02a091b
to
9780e27
Compare
@richiprosima please test this |
Mario-DL
approved these changes
Apr 4, 2024
Mario-DL
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Apr 4, 2024
Failed tests are unrelated to this PR, ready to merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4335 done by Mergify.
Cherry-pick of 6cb5ebb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com