Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20542] Improve CI management #4526

Closed
wants to merge 12 commits into from
Closed

[20542] Improve CI management #4526

wants to merge 12 commits into from

Conversation

JesusPoderoso
Copy link
Contributor

Description

This PR unifies the CI in all workflows to follow this behavior:

  • Trigger CI in all pull requests which HEAD branch is set to this supported branch version
  • Remove any CI trigger on push events and nightly
  • Include missing ignore files for the sanitizer event trigger.
  • Includes ubuntu CI as a workflow dispatch event
  • Rename sanitizer job as "address-sanitizer"
  • Remove unused action, and migrate apt package dependencies to eProsima CI
  • Remove Windows test report job step

master related PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Mar 7, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Mar 7, 2024
@JesusPoderoso JesusPoderoso self-assigned this Mar 7, 2024
@JLBuenoLopez JLBuenoLopez force-pushed the 3.0.x-devel branch 3 times, most recently from ba2327e to eb65c57 Compare March 8, 2024 06:45
@JesusPoderoso JesusPoderoso force-pushed the hotfix/ci_version_management_3.0.x branch from 27f13d1 to 21a4931 Compare March 11, 2024 09:44
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 1f2e8b7 to 30d4fcd Compare March 21, 2024 07:18
elianalf and others added 9 commits March 25, 2024 12:32
@elianalf @EduPonz
GitHub CI for 3.0.x (#4358)
9734695 
* Refs #19452: Change github workflow for discovery-server

Signed-off-by: elianalf <[email protected]>

* Refs #19452: Change github workflow for documentation

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
@JLBuenoLopez @EduPonz
Branch-out v3.0.0 (#4251)
ce956e3 
* Refs #19452: branch-out v3.0.0

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update XML schema name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove doc legacy folder. Move github banner to resources folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove .settings folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove legacy m4 folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove legace files from utils folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: rename to FASTDDS_DEFAULT_PROFILES_FILE and FASTDDS_DEFAULT_PROFILES

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update XML Schema name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update to Fast DDS, remove references to FastRTPS, remove legacy files

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update Doxygen modules

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: examples, use fastdds headers instead of fastrtps ones

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: rename security logging macros

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: use fastdds headers

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update to fastdds headers in public headers

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update to Fast DDS configuration files. Rename deprecation macro

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: use fastdds headers. Update header guards

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update fastrtps.rc

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove System deprecated class

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove DataWriter deprecated methods

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove deprecated methods in ServerAttributes

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove deprecated method in LocatorList

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove deprecated attributes in TCPTransportDescriptor

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove SampleInfo deprecated constexpr

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove deprecated participant discovery callback

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove TypeObject deprecated API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove RPC headers deprecated API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: rename project to Fast DDS. Update examples, tools and fuzzer CMakeLists. Changes required to build library after updating to fastdds headers

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fix examples build

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fixes in test suite

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: linters

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove deprecated API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update versions.md

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fix Windows warning

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove PSM source files and tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: move TopicAttributes implementation to src/cpp/rtps/attributes folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: sort alphabetically source files

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove Fast RTPS legacy API implementation

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: remove PSM API headers and implementation. Fixes to ensure tests build correctly

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: update to libfastdds.version name and remove exported dds namespace

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: apply review suggestion related to XML header

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: missing XML xmlns

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fixes in TCPv6 unit tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: keep legacy installation folder until migration is completed

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19452: fixes in TCPv4 unit tests

Signed-off-by: elianalf <[email protected]>

* Refs #19452: Remove Readme.html.in installation since it has been removed

Signed-off-by: elianalf <[email protected]>

* Refs #19452: Remove fastrtps_example.cpp references

Signed-off-by: elianalf <[email protected]>

* Refs #19452: Add head branch for discovery-server in github ci action

Signed-off-by: elianalf <[email protected]>

* Refs 19452: Update default branch for asan

Signed-off-by: elianalf <[email protected]>

* Refs #19452: Change Mac Github CI to work for 3.0.x-devel

Signed-off-by: elianalf <[email protected]>

* Refs 19452: Add namespace where missing

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: elianalf <[email protected]>
Co-authored-by: elianalf <[email protected]>

Fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@elianalf @EduPonz
Remove head_ref branch for discovery_server in sanitizer action (#4450)
3585ffe 
Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Remove deprecated fastrtps tests (#4270)
16a7448 
* Refs #20340: Remove deprecated fastrtps tests

Signed-off-by: elianalf <[email protected]>

Refs #20340: Restore XML parser tests

Signed-off-by: elianalf <[email protected]>

* Refs #20340: Update version.md file

Signed-off-by: elianalf <[email protected]>

* Refs 20340: Remove no longer supported FASTRTPS_API_TESTS

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Remove fixed_size_string file in fastrtps (#4269)
4208dd0 
* Refs #20392: Remove fastrtps fixed_size_string lib

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Update tests dependencies

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Update namespace fastcdr

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Reorder libraries to follow google style order

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Remove include of unused fixed_size_string

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Remove deprecated tests of fixed_size_string

Signed-off-by: elianalf <[email protected]>

* Refs #20392: Uncrustify

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
@JLBuenoLopez @EduPonz
Make XML Parser API private (#4318)
c9f228d 
* Refs #20301: move XML Parser implementation to root source folder

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: sort alphabetically source files

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: make XML Parser private

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: remove private headers from Blackbox tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: new LibrarySettings class superseding LibrarySettingsAttributes

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: add library settings DDS & RTPS API. RTPSDomainTests testing the new API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: library settings DDS API test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: generate monitor service types in blackbox types and use them in corresponding test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: XML profile manager get dynamic type builder wrapper and related test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: refactor XML library settings, use new migrated structure

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: migrate to public API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: reintroduce private headers in blackbox tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: update versions.md and copyright

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: remove exportation macro from private API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: remove participant without using mocked code

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: apply review suggestion

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: linters

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: avoid using protected interface name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: avoid using non-exported API in ParticipantTests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: linters

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: fix Publisher and Subscriber tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: add get_topic_attributes_from_profile API

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: get topic attributes from profile test

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: fixes after rebase

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: fix Windows warning

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: linters

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: fix Windows warning

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: fix memory leak

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20301: Run Github Windows CI on 3.0.x-devel PRs

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: EduPonz <[email protected]>
@EduPonz
Migrate DLL API exporter and auto linkage to fastdds (#4500)
2ef50ea 
* Refs #20569: Rename RTPS_DllAPI to FASTDDS_EXPORTED_API

Signed-off-by: EduPonz <[email protected]>

* Refs #20569: Move fastrtps/fastrtps_dll.h to fastdds/fastdds_dll.hpp

Signed-off-by: EduPonz <[email protected]>

* Refs #20569: Move fastrtps/eProsima_auto_link.h to fastdds/fastdds_auto_link.hpp

Signed-off-by: EduPonz <[email protected]>

* Refs #20569: Uncrustify

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
@elianalf @EduPonz
Change windows file names (#4576)
4fe573a 
* Refs #20390: Change fastdds-config.cmake name

Signed-off-by: elianalf <[email protected]>

* Refs #20390: Change fastdds.manifest.in name

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
@elianalf @EduPonz
Migrate classes from include/fastrtps to fastdds (#4518)
a0bdc0e 
* Refs #20566: Migrate fastrtps/attributes/TopicAttributes.h to fastdds/rtps/attributes

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/IPFinder.h to fastdds/utils

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/IPLocator.h to fastdds/utils

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/collections to fastdds/utils/collections

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/fixed_size_bitmap.hpp to fastdds/utils/

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/md5.h to fastdds/utils

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/TimedConditionVariable.hpp to fastdds/utils

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Migrate fastrtps/utils/TimedMutex.hpp to fastdds/utils

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Uncrustify

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>

* Refs #20566: Reorder header following google style

Signed-off-by: elianalf <[email protected]>

* Regenerate file with updated headers

Signed-off-by: elianalf <[email protected]>

* Refs #20566: fix rebase error

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
Signed-off-by: EduPonz <[email protected]>
@EduPonz EduPonz force-pushed the hotfix/ci_version_management_3.0.x branch from 47cb5ec to 1f05020 Compare March 27, 2024 06:15
@EduPonz
Copy link

EduPonz commented Mar 27, 2024

This is not needed anymore

@EduPonz EduPonz closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JesusPoderoso JesusPoderoso

Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JesusPoderoso @EduPonz @elianalf @JLBuenoLopez