Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20542] Fix input branch on reusable windows CI #4539

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 9, 2024

Description

The reusable windows CI workflow was effectively ignoring the input branch, which results in all nightly jobs running with master.

@Mergifyio backport 2.10.x

This changes have also been applied on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A; The code follows the style guidelines of this project.
  • N/A; Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A; Any new/modified methods have been properly documented using Doxygen.
  • N/A; Changes are ABI compatible.
  • N/A; Changes are API compatible.
  • N/A; New feature has been added to the versions.md file (if applicable).
  • N/A; New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.14.0 - Frozen milestone Mar 9, 2024
@EduPonz
Copy link
Author

EduPonz commented Mar 9, 2024

@Mergifyio backport 2.10.x

Copy link
Contributor

mergify bot commented Mar 9, 2024

backport 2.10.x

✅ Backports have been created

@EduPonz EduPonz merged commit a97e7ab into master Mar 9, 2024
9 of 10 checks passed
@EduPonz EduPonz deleted the hotfix/windows_nightly branch March 9, 2024 12:58
mergify bot pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit a97e7ab)

# Conflicts:
#	.github/workflows/ubuntu-ci.yml
MiguelCompany added a commit that referenced this pull request Mar 11, 2024
* Fix input branch on reusable windows CI (#4539)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit a97e7ab)

# Conflicts:
#	.github/workflows/ubuntu-ci.yml

* Fix conflicts

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants