-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20625] Monitor service properly managing instances #4564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@richiprosima please test this |
elianalf
suggested changes
Mar 20, 2024
Signed-off-by: Mario Dominguez <[email protected]>
@richiprosima please test this |
Signed-off-by: Mario Dominguez <[email protected]>
@richiprosima please test this |
elianalf
approved these changes
Mar 25, 2024
@Mergifyio backport 2.13.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Refs #20625: Add BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Add Monitor Service Fix. Use DataWriterHistory Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Fix MonitorService Unittests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Apply rev suggestion Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Add more comments in BB tests Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 84960eb) # Conflicts: # test/unittest/statistics/rtps/CMakeLists.txt
12 tasks
EduPonz
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Monitor service properly managing instances (#4564) * Refs #20625: Add BB tests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Add Monitor Service Fix. Use DataWriterHistory Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Fix MonitorService Unittests Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Apply rev suggestion Signed-off-by: Mario Dominguez <[email protected]> * Refs #20625: Add more comments in BB tests Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> (cherry picked from commit 84960eb) # Conflicts: # test/unittest/statistics/rtps/CMakeLists.txt * Fix conflicts Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Mario Domínguez López <[email protected]> Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a misbehavior of the monitor service that was not truly managing instances since it requires a
DataWriterHistory
instead of aWriterHistory
. Cachechanges owned by instances are now properly removed in successive updates to the same instance.@Mergifyio backport 2.13.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist