Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20592] Fix hidden overloaded virtual methods (backport #4516) #4593

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 20, 2024

Description

Before this PR, compiling with GCC option -Woverloaded-virtual resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:

  1. Fixes all those warnings
  2. Adds more warning reporting options GCC in Ubuntu CI on Github

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4516 done by [Mergify](https://mergify.com).

* Refs #20592: Fix for test

Signed-off-by: EduPonz <[email protected]>

* Refs #20592: Fix for examples

Signed-off-by: EduPonz <[email protected]>

* Refs #20592: Add more warning flags to Ubuntu CI

Signed-off-by: EduPonz <[email protected]>

* Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 63cc242)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
#	examples/C++/RTPSTest_persistent/TestReaderPersistent.h
#	examples/C++/RTPSTest_persistent/TestWriterPersistent.h
#	examples/C++/RTPSTest_registered/TestReaderRegistered.h
#	examples/C++/RTPSTest_registered/TestWriterRegistered.h
#	examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h
#	src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp
#	test/blackbox/common/DDSBlackboxTestsBasic.cpp
#	test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp
#	test/blackbox/common/DDSBlackboxTestsDiscovery.cpp
#	test/blackbox/common/DDSBlackboxTestsFindTopic.cpp
#	test/dds/communication/SubscriberDynamic.cpp
#	test/dds/communication/security/PublisherModule.hpp
#	test/dds/communication/security/SubscriberModule.hpp
#	test/unittest/dds/participant/ParticipantTests.cpp
#	test/unittest/dds/subscriber/DataReaderHistoryTests.cpp
#	test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Mar 20, 2024
Copy link
Contributor Author

mergify bot commented Mar 20, 2024

Cherry-pick of 63cc242 has failed:

On branch mergify/bp/2.6.x/pr-4516
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 63cc242b2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   examples/C++/DDS/BasicConfigurationExample/BasicConfigurationPublisher.h
	modified:   examples/C++/DDS/BasicConfigurationExample/BasicConfigurationSubscriber.h
	modified:   examples/C++/DDS/LivelinessQoS/LivelinessSubscriber.h
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPClient.h
	modified:   test/blackbox/api/dds-pim/PubSubParticipant.hpp
	modified:   test/blackbox/api/dds-pim/PubSubReader.hpp
	modified:   test/blackbox/api/dds-pim/PubSubWriter.hpp
	modified:   test/blackbox/api/dds-pim/PubSubWriterReader.hpp
	modified:   test/blackbox/common/RTPSWithRegistrationReader.hpp
	modified:   test/blackbox/common/RTPSWithRegistrationWriter.hpp
	modified:   test/dds/communication/PublisherDynamic.cpp
	modified:   test/dds/communication/PublisherModule.hpp
	modified:   test/dds/communication/SubscriberModule.hpp
	modified:   test/dds/discovery/ParticipantModule.hpp
	modified:   test/performance/latency/LatencyTestTypes.hpp
	modified:   test/performance/throughput/ThroughputTypes.hpp
	modified:   test/unittest/dds/publisher/DataWriterTests.cpp
	modified:   test/unittest/dds/publisher/PublisherTests.cpp
	modified:   test/unittest/dds/status/ListenerTests.cpp
	modified:   test/unittest/dds/subscriber/DataReaderTests.cpp
	modified:   test/unittest/dds/subscriber/FooBoundedTypeSupport.hpp
	modified:   test/unittest/dds/subscriber/FooTypeSupport.hpp
	modified:   test/unittest/dds/topic/TopicTests.cpp
	modified:   test/unittest/statistics/dds/StatisticsDomainParticipantTests.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   .github/workflows/reusable-ubuntu-ci.yml
	both modified:   examples/C++/RTPSTest_persistent/TestReaderPersistent.h
	both modified:   examples/C++/RTPSTest_persistent/TestWriterPersistent.h
	both modified:   examples/C++/RTPSTest_registered/TestReaderRegistered.h
	both modified:   examples/C++/RTPSTest_registered/TestWriterRegistered.h
	deleted by us:   examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h
	both modified:   src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp
	both modified:   test/blackbox/common/DDSBlackboxTestsBasic.cpp
	deleted by us:   test/blackbox/common/DDSBlackboxTestsDataRepresentationQos.cpp
	both modified:   test/blackbox/common/DDSBlackboxTestsDiscovery.cpp
	deleted by us:   test/blackbox/common/DDSBlackboxTestsFindTopic.cpp
	both modified:   test/dds/communication/SubscriberDynamic.cpp
	deleted by us:   test/dds/communication/security/PublisherModule.hpp
	deleted by us:   test/dds/communication/security/SubscriberModule.hpp
	both modified:   test/unittest/dds/participant/ParticipantTests.cpp
	deleted by us:   test/unittest/dds/subscriber/DataReaderHistoryTests.cpp
	deleted by us:   test/unittest/statistics/dds/StatisticsDomainParticipantStatusQueryableTests.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@EduPonz EduPonz added this to the v2.6.8 milestone Mar 20, 2024
@Mario-DL
Copy link
Member

@EduPonz would you mind addressing the conflicts here ?

@Mario-DL
Copy link
Member

Friendly ping @EduPonz

@EduPonz
Copy link

EduPonz commented Mar 26, 2024

@EduPonz EduPonz closed this Mar 26, 2024
@mergify mergify bot deleted the mergify/bp/2.6.x/pr-4516 branch March 26, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Backport PR wich git cherry pick failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants