-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20652] Improve filtering of DNS tests #4603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
elianalf
approved these changes
Mar 25, 2024
@richiprosima Please test this |
@Mergifyio backport 2.13.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Refs #20652. Fix windows command to check local DNS name. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Correctly combine blackbox filters. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Informational message on participant test. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Use correct command on Apple to check local DNS name. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Use filter on RTPS blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix typo. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix filter in LocatorTests. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Filter with grep in mac. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix concurrency group in ubuntu-ci. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 1d9d559)
9 tasks
EduPonz
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Refs #20652. Fix windows command to check local DNS name. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Correctly combine blackbox filters. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Informational message on participant test. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Use correct command on Apple to check local DNS name. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Use filter on RTPS blackbox tests. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix typo. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix filter in LocatorTests. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Filter with grep in mac. Signed-off-by: Miguel Company <[email protected]> * Refs #20652. Fix concurrency group in ubuntu-ci. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 1d9d559) Co-authored-by: Miguel Company <[email protected]>
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When both PKCS#11 and DNS tests had to be disabled, the filter expression for gtest was incorrectly generated.
This made Ubuntu and MacOS CI on github fail.
Additionally, this PR fixes the commands used to detect whether the DNS local entries for the corresponding tests have been added, and adds some related informational messages to the CMake files.
@Mergifyio backport 2.13.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist