Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20648] Only run PRs CI when run-ci label is added (backport #4599) #4615

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 25, 2024

Description

This PR changes the way Github CI is managed. From now on, to run CI, a label run-ci needs to be added to the PR. Once the CI starts, that label is removed and ci-pending one is added.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Changes are ABI compatible.

  • N/A: Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4599 done by [Mergify](https://mergify.com).

* Refs #20648: Only run PRs CI when run-ci label is added

Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Correctly add ci-pending label

Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Fix documentation trigger

Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Add ci-pending label in mac CI

Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Set eProsima-CI version to v0 on add and remove labels actions

Signed-off-by: EduPonz <[email protected]>

* Refs #20648: Change Github workflows trigger to 'review_requested'

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit d0a334b)

# Conflicts:
#	.github/workflows/address-sanitizers.yaml
#	.github/workflows/documentation-tests.yaml
#	.github/workflows/mac-ci.yml
#	.github/workflows/thread-sanitizer.yaml
#	.github/workflows/ubuntu-ci.yml
#	.github/workflows/windows-ci.yml
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Mar 25, 2024
Copy link
Contributor Author

mergify bot commented Mar 25, 2024

Cherry-pick of d0a334b has failed:

On branch mergify/bp/2.6.x/pr-4599
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit d0a334b11.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/reusable-mac-ci.yml
	modified:   .github/workflows/reusable-ubuntu-ci.yml
	modified:   .github/workflows/reusable-windows-ci.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/address-sanitizers.yaml
	both modified:   .github/workflows/documentation-tests.yaml
	both modified:   .github/workflows/mac-ci.yml
	both modified:   .github/workflows/thread-sanitizer.yaml
	both modified:   .github/workflows/ubuntu-ci.yml
	both modified:   .github/workflows/windows-ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@JesusPoderoso JesusPoderoso added this to the v2.6.8 milestone Mar 25, 2024
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso added skip-ci Automatically pass CI and removed conflicts Backport PR wich git cherry pick failed labels Mar 25, 2024
@Mario-DL Mario-DL added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Apr 1, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 1, 2024
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Apr 1, 2024
@EduPonz EduPonz merged commit 39b3d58 into 2.6.x Apr 1, 2024
18 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.6.x/pr-4599 branch April 1, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants