-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20592][20679] Fix hidden overloaded virtual methods #4624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
hotfix/hidden_overloads/2.10.x
branch
from
April 1, 2024 12:45
44c0cff
to
e209710
Compare
MiguelCompany
previously approved these changes
Apr 1, 2024
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: EduPonz <[email protected]>
Signed-off-by: EduPonz <[email protected]>
EduPonz
force-pushed
the
hotfix/hidden_overloads/2.10.x
branch
from
April 2, 2024 09:38
e209710
to
1c00b30
Compare
MiguelCompany
requested changes
Apr 2, 2024
EduPonz
force-pushed
the
hotfix/hidden_overloads/2.10.x
branch
from
April 2, 2024 10:57
f78a5ed
to
670c7c7
Compare
MiguelCompany
requested changes
Apr 2, 2024
Signed-off-by: EduPonz <[email protected]>
EduPonz
force-pushed
the
hotfix/hidden_overloads/2.10.x
branch
from
April 2, 2024 12:11
670c7c7
to
e1576a3
Compare
MiguelCompany
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@richiprosima Please test this |
@richiprosima please test mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a backport combining:
Before this PR, compiling with GCC option
-Woverloaded-virtual
resulted in compilation warnings due to overloaded virtual methods being hidden in derived classes that do not override all the parent's overloads. This PR:pull_request
eventsIt substitutes:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist