[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job #4628

EduPonz · 2024-03-27T11:05:02Z

Description

This PR extends the ubuntu-build-and-test-documentation Github CI job to include Fast DDS Python in the build.
It also uses a new action from eProsima-CI to deduce which branch to use:

[20694] Add Ubuntu get_related_branch_from_repo eProsima-CI#82

TODO:

Drop the commit Refs #20694: DROP Run docs CI even when skip-ci that is added to ease reviewing the PR
Pin used version of get_related_branch_from_repo once eProsima-CI releases the new action

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

elianalf

Partial review

.github/workflows/documentation-tests.yaml

Signed-off-by: EduPonz <[email protected]>

elianalf · 2024-04-02T13:38:42Z

LGTM. Here the test was manually ran and checkout on the right branches.
Next step will be drop the commit Refs #20694: DROP Run docs CI even when skip-ci

Signed-off-by: EduPonz <[email protected]>

EduPonz · 2024-04-02T14:28:52Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-04-02T14:29:12Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4642 [20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) has been created for branch 2.13.x but encountered conflicts
#4643 [20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) has been created for branch 2.10.x but encountered conflicts
#4644 [20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) has been created for branch 2.6.x but encountered conflicts

* Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <[email protected]> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit decf689) # Conflicts: # .github/workflows/documentation-tests.yaml

* Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <[email protected]> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit decf689)

…#4644) * Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <[email protected]> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit decf689) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>

…#4642) * Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <[email protected]> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit decf689) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>

…#4644) * Refs #20694: Use ci.repos to get gtest Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use eProsima-CI to choose Fast DDS Python branch Signed-off-by: EduPonz <[email protected]> * Refs #20694: Get deduced branch output correctly Signed-off-by: EduPonz <[email protected]> * Refs #20694: Use CMake 3.22.6 Signed-off-by: EduPonz <[email protected]> * Refs #20694: Pin get_related_branch_from_repo action version to v0 Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> (cherry picked from commit decf689) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>

EduPonz added this to the v2.14.1 milestone Mar 27, 2024

EduPonz added the skip-ci Automatically pass CI label Mar 27, 2024

EduPonz requested a review from elianalf March 27, 2024 11:06

github-actions bot added the ci-pending PR which CI is running label Mar 27, 2024

EduPonz force-pushed the ci/build_docs_with_python branch from 4fd76ab to d521e75 Compare March 27, 2024 11:14

EduPonz requested review from elianalf and removed request for elianalf March 27, 2024 11:14

EduPonz force-pushed the ci/build_docs_with_python branch from d521e75 to d0b5e61 Compare March 27, 2024 11:33

EduPonz marked this pull request as ready for review March 27, 2024 11:41

elianalf requested review from elianalf and removed request for elianalf March 27, 2024 15:55

elianalf reviewed Mar 27, 2024

View reviewed changes

.github/workflows/documentation-tests.yaml Show resolved Hide resolved

.github/workflows/documentation-tests.yaml Show resolved Hide resolved

JesusPoderoso suggested changes Apr 1, 2024

View reviewed changes

.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved

.github/workflows/documentation-tests.yaml Outdated Show resolved Hide resolved

EduPonz added 3 commits April 2, 2024 14:59

Refs #20694: Use ci.repos to get gtest

4d6bda3

Signed-off-by: EduPonz <[email protected]>

Refs #20694: Use eProsima-CI to choose Fast DDS Docs branch

9701e68

Signed-off-by: EduPonz <[email protected]>

Refs #20694: Use eProsima-CI to choose Fast DDS Python branch

471057b

Signed-off-by: EduPonz <[email protected]>

EduPonz force-pushed the ci/build_docs_with_python branch from d0b5e61 to 24d0ba9 Compare April 2, 2024 12:59

EduPonz requested review from elianalf and removed request for elianalf April 2, 2024 12:59

EduPonz added 3 commits April 2, 2024 16:15

Refs #20694: Get deduced branch output correctly

a5ab317

Signed-off-by: EduPonz <[email protected]>

Refs #20694: Use CMake 3.22.6

76b14a9

Signed-off-by: EduPonz <[email protected]>

Refs #20694: Pin get_related_branch_from_repo action version to v0

8d042a4

Signed-off-by: EduPonz <[email protected]>

EduPonz force-pushed the ci/build_docs_with_python branch from 52b307d to 8d042a4 Compare April 2, 2024 14:27

elianalf removed the skip-ci Automatically pass CI label Apr 2, 2024

elianalf requested review from elianalf and removed request for elianalf April 2, 2024 14:29

elianalf approved these changes Apr 2, 2024

View reviewed changes

EduPonz merged commit decf689 into master Apr 3, 2024
4 of 11 checks passed

EduPonz deleted the ci/build_docs_with_python branch April 3, 2024 05:14

This was referenced Apr 3, 2024

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) #4642

Merged

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) #4643

Merged

mergify bot mentioned this pull request Apr 3, 2024

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job (backport #4628) #4644

Merged

10 tasks

EduPonz removed the ci-pending PR which CI is running label Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job #4628

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job #4628

EduPonz commented Mar 27, 2024 •

edited

Loading

elianalf left a comment

elianalf commented Apr 2, 2024 •

edited

Loading

EduPonz commented Apr 2, 2024

mergify bot commented Apr 2, 2024 •

edited

Loading

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job #4628

[20694] Build Fast DDS Python bindings in Fast DDS Docs Github CI job #4628

Conversation

EduPonz commented Mar 27, 2024 • edited Loading

Description

Contributor Checklist

Reviewer Checklist

elianalf left a comment

Choose a reason for hiding this comment

elianalf commented Apr 2, 2024 • edited Loading

EduPonz commented Apr 2, 2024

mergify bot commented Apr 2, 2024 • edited Loading

✅ Backports have been created

EduPonz commented Mar 27, 2024 •

edited

Loading

elianalf commented Apr 2, 2024 •

edited

Loading

mergify bot commented Apr 2, 2024 •

edited

Loading