Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonitorService fails serializing Data(w)/Data(r) in some cases [20772] #4670

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Apr 8, 2024

Description

This bug was found testing ShapesDemo against 3.0.x-devel. The problem is DataRepresentationQos is not taken into account when calculating cdr serialized size of Data(w)/Data(r). This PR fixes this.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title MonitorService fails serializing Data(w)/Data(r) in some cases MonitorService fails serializing Data(w)/Data(r) in some cases [20772] Apr 8, 2024
@EduPonz EduPonz added this to the v2.14.1 milestone Apr 10, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz self-requested a review April 23, 2024 10:48
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 23, 2024
@EduPonz EduPonz merged commit 38aa0f6 into master Apr 24, 2024
8 of 12 checks passed
@EduPonz EduPonz deleted the bugfix/20771 branch April 24, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants