-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20765] Make RTPS reader implementations private #4674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
JesusPoderoso
force-pushed
the
3.0.x-devel
branch
from
April 12, 2024 05:50
943b988
to
2c47b5e
Compare
github-actions
bot
force-pushed
the
3.0.x-devel
branch
from
April 16, 2024 08:56
2c47b5e
to
c978d52
Compare
EduPonz
force-pushed
the
3.0.x-devel
branch
3 times, most recently
from
April 23, 2024 05:52
5148f5d
to
bd83bb2
Compare
EduPonz
force-pushed
the
3.0.x-devel
branch
2 times, most recently
from
May 13, 2024 09:26
08ee62b
to
623db82
Compare
elianalf
force-pushed
the
feature/make_rtps_reader_impl_private
branch
from
May 14, 2024 13:38
f23b852
to
3bbc297
Compare
@elianalf There are conflicts here, so a rebase is necessary. |
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
MiguelCompany
requested changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to also change the extension of the moved headers from .h
to `.hpp
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
elianalf
force-pushed
the
feature/make_rtps_reader_impl_private
branch
from
May 24, 2024 09:14
3bbc297
to
fc47457
Compare
Signed-off-by: elianalf <[email protected]>
elianalf
force-pushed
the
feature/make_rtps_reader_impl_private
branch
from
May 24, 2024 09:56
01662e8
to
f47830e
Compare
MiguelCompany
requested changes
May 24, 2024
Signed-off-by: elianalf <[email protected]>
MiguelCompany
approved these changes
May 27, 2024
@richiprosima please test_3 this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes RTPS reader implementations private:
Related PR in Fast DDS Python:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist