Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20653] Increase sleep to miss the deadline in macOS flaky tests (backport #4636) #4680

Merged
merged 1 commit into from
May 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 10, 2024

Description

This PR increases the sleep between samples sent to miss the deadline in ownership flaky tests " exclusive_kind_non_keyed_reliable_deadline"

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • Changes are ABI compatible.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4636 done by [Mergify](https://mergify.com).

@EduPonz EduPonz added this to the v2.10.4 milestone Apr 10, 2024
@MiguelCompany MiguelCompany self-requested a review April 15, 2024 07:24
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 15, 2024
@MiguelCompany
Copy link
Member

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Apr 17, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Apr 23, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany April 23, 2024 14:51
@MiguelCompany
Copy link
Member

@richiprosima Please test this

@MiguelCompany
Copy link
Member

@Mergifyio rebase

@MiguelCompany MiguelCompany removed their request for review May 20, 2024 06:33
Copy link
Contributor Author

mergify bot commented May 20, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany
Copy link
Member

@Mergifyio rebase

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline

Signed-off-by: elianalf <[email protected]>

* Refs #20653: Add lease duration and increase deadline

Signed-off-by: elianalf <[email protected]>

---------

Signed-off-by: elianalf <[email protected]>
(cherry picked from commit 421bdb2)
Copy link
Contributor Author

mergify bot commented May 21, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany May 21, 2024 12:43
@MiguelCompany
Copy link
Member

@richiprosima Please test this

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests this PR modifies have passed in all platforms

@MiguelCompany MiguelCompany merged commit aa611bd into 2.10.x May 21, 2024
10 of 16 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-4636 branch May 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants