-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20653] Increase sleep to miss the deadline in macOS flaky tests (backport #4636) #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
MiguelCompany
approved these changes
Apr 15, 2024
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4636
branch
from
April 17, 2024 06:23
0b76ce1
to
a2d0c07
Compare
@richiprosima Please test this |
@Mergifyio rebase |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4636
branch
from
April 23, 2024 14:51
a2d0c07
to
739e7d5
Compare
✅ Branch has been successfully rebased |
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
April 23, 2024 14:51
@richiprosima Please test this |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4636
branch
from
May 20, 2024 06:34
739e7d5
to
cc19ea4
Compare
@Mergifyio rebase |
* Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_non_keyed_reliable_deadline Signed-off-by: elianalf <[email protected]> * Refs #20653: Increase sleep to miss the deadline in test exclusive_kind_keyed_reliable_deadline Signed-off-by: elianalf <[email protected]> * Refs #20653: Add lease duration and increase deadline Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> (cherry picked from commit 421bdb2)
✅ Branch has been successfully rebased |
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-4636
branch
from
May 21, 2024 12:39
cc19ea4
to
5f6afe6
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
May 21, 2024 12:43
@richiprosima Please test this |
MiguelCompany
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests this PR modifies have passed in all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases the sleep between samples sent to miss the deadline in ownership flaky tests " exclusive_kind_non_keyed_reliable_deadline"
@Mergifyio backport 2.13.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4636 done by [Mergify](https://mergify.com).