Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20732] Improve xml loading method in fuzz_XMLProfiles #4685

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 15, 2024

Description

This PR improves the XML loading process in fuzz_XMLProfiles.cxx. LLVMFuzzerTestOneInput() accepts a XML array as argument, so this PR replaces loadXMLFile(), which requires copying the XML array to a file, with load_XML_profiles_string(), which directly takes an array.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v2.14.1 milestone Apr 15, 2024
@MiguelCompany MiguelCompany self-requested a review April 15, 2024 12:32
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 15, 2024
@MiguelCompany MiguelCompany added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Apr 15, 2024
@MiguelCompany MiguelCompany self-requested a review April 15, 2024 12:43
@EduPonz EduPonz merged commit f1373f9 into master Apr 16, 2024
8 checks passed
@EduPonz EduPonz deleted the feature/improve_fuzz_xmlprofile branch April 16, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants