Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20786] Build ShapesDemo on Ubuntu Github CI (backport #4678) #4688

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 17, 2024

Description

This PR adds Fast DDS Shapes Demo to the packages built in Ubuntu Gibthub CI so we have certainty that changes in Fast DDS do not broke Shapes Demo compilation.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A: Changes are ABI compatible.

  • N/A: Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4678 done by [Mergify](https://mergify.com).

@EduPonz EduPonz added this to the v2.13.5 milestone Apr 17, 2024
@JesusPoderoso JesusPoderoso self-requested a review April 17, 2024 08:38
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 17, 2024
JesusPoderoso

This comment was marked as outdated.

* Refs #20786: Build ShapesDemo on Ubuntu Github CI

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Install Qt

Signed-off-by: eduponz <[email protected]>

* Refs #20786: Remove unnecessary entry in ci.meta

Signed-off-by: eduponz <[email protected]>

---------

Signed-off-by: eduponz <[email protected]>
(cherry picked from commit a35c846)
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Apr 17, 2024
@JesusPoderoso JesusPoderoso self-requested a review April 17, 2024 09:29
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor

As this PR is only adding ShapesDemo build on Ubuntu GitHub CI, it is the only CI that has been run (and has passed)
PR ready to merge

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels Apr 18, 2024
@EduPonz EduPonz merged commit 62441c4 into 2.13.x Apr 18, 2024
7 of 11 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.13.x/pr-4678 branch April 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants