Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed warning (backport #4693) #4704

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 18, 2024

There is a new warning on CI https://ci.ros2.org/view/packaging/job/packaging_linux/3405/clang-tidy/folder.112366245/

This should fix the warning


This is an automatic backport of pull request #4693 done by Mergify.

* Removed warning

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added suggestions

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 8258507)
@mergify mergify bot mentioned this pull request Apr 18, 2024
@JesusPoderoso JesusPoderoso added this to the v2.6.8 milestone Apr 18, 2024
@JesusPoderoso JesusPoderoso added the no-test Skip CI tests if PR marked with this label label Apr 18, 2024
@Mario-DL Mario-DL added ci-pending PR which CI is running and removed no-test Skip CI tests if PR marked with this label labels Apr 18, 2024
@Mario-DL Mario-DL self-requested a review April 18, 2024 12:52
@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Apr 23, 2024
@Mario-DL
Copy link
Member

@richiprosima please test this

Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, github cis failed because the no-test was added later.

@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Apr 23, 2024
@MiguelCompany MiguelCompany merged commit eb52759 into 2.6.x Apr 23, 2024
12 of 17 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.6.x/pr-4693 branch April 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants