Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21226] Update types regeneration script homing path (backport #5093) #5107

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

Description

This PR updates the type regeneration utils script to request itself to be launched from project root directory, instead of from the utils script folder. This is needed to standardize the Fast DDS Gen CI.
Related PR:

(tested locally)

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5093 done by [Mergify](https://mergify.com).

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 47cb38c)

# Conflicts:
#	utils/scripts/update_generated_code_from_idl.sh
Copy link
Contributor Author

mergify bot commented Jul 26, 2024

Cherry-pick of 47cb38c has failed:

On branch mergify/bp/2.6.x/pr-5093
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 47cb38c33.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   utils/scripts/update_generated_code_from_idl.sh

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Jul 26, 2024
@JesusPoderoso JesusPoderoso removed the conflicts Backport PR wich git cherry pick failed label Jul 26, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 26, 2024 11:10
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jul 26, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 26, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jul 26, 2024
@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso July 26, 2024 11:11
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added this to the v2.6.10 milestone Jul 26, 2024
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 26, 2024
@juanlofer-eprosima juanlofer-eprosima merged commit a6db7de into 2.6.x Sep 2, 2024
7 of 21 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/2.6.x/pr-5093 branch September 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants