Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21563] TypeLookupService: also register the minimal created from the received complete TypeObject #5181

Merged
merged 3 commits into from
Sep 5, 2024
Merged

[21563] TypeLookupService: also register the minimal created from the received complete TypeObject #5181

merged 3 commits into from
Sep 5, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Aug 30, 2024 •
edited by Mario-DL
Loading

Description

DDS Router is having problems redirecting the TypeInformation from one side to another. This PR tries to solve this making the TypeLookupService registers the EK_MINIMAL TypeObject built from the received EK_COMPLETE TypeObject.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #21509. Fix
7bb4b3f 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21322. Fixes for ROS2
5c5d9f9 
Signed-off-by: Ricardo González Moreno <[email protected]>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 2, 2024
@richiware
Refs #21322. Fix unit tests
4af8bf8 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware requested review from Mario-DL and removed request for Mario-DL September 3, 2024 07:01
@Mario-DL Mario-DL added this to the v3.0.1 milestone Sep 4, 2024
@MiguelCompany MiguelCompany added the needs-review PR that is ready to be reviewed label Sep 4, 2024
@rsanchez15 rsanchez15 changed the title TypeLookupService: also register the minimal created from the received complete TypeObject [21563] TypeLookupService: also register the minimal created from the received complete TypeObject Sep 4, 2024
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL September 4, 2024 14:03
@Mario-DL Mario-DL mentioned this pull request Sep 4, 2024
Merged
@MiguelCompany MiguelCompany mentioned this pull request Sep 5, 2024
Merged
13 tasks
Mario-DL
Mario-DL approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Mac failed test unrelated.

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Sep 5, 2024
@MiguelCompany MiguelCompany merged commit bf3d0c0 into master Sep 5, 2024
31 of 45 checks passed
@MiguelCompany MiguelCompany deleted the feature/also-register-minimal branch September 5, 2024 10:37
paxifaer pushed a commit to paxifaer/Fast-DDS that referenced this pull request Sep 7, 2024
@richiware @paxifaer
TypeLookupService: also register the minimal created from the receive…
2b80fa7 
…d complete TypeObject (eProsima#5181)

* Refs #21509. Fix

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21322. Fixes for ROS2

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21322. Fix unit tests

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: paxifaer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @Mario-DL @MiguelCompany