Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21680] Include EPROSIMA_USER_DLL_EXPORT in Fast DDS CMakeLists #5240

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Sep 16, 2024

Description

This PR adds support for DLL export on Windows by including the EPROSIMA_USER_DLL_EXPORT macro in the library's CMakeLists.txt. These changes ensure that functions and classes are correctly exported when the library is built as a DLL on Windows, allowing other modules or executables to link properly.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@LuciaEchevarria99 LuciaEchevarria99 added this to the v3.0.2 milestone Sep 16, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 16, 2024
@rsanchez15 rsanchez15 added the skip-ci Automatically pass CI label Sep 16, 2024
@rsanchez15 rsanchez15 requested review from richiware and removed request for richiware September 16, 2024 08:00
@LuciaEchevarria99 LuciaEchevarria99 changed the title Include EPROSIMA_USER_DLL_EXPORT in Fast DDS CMakeLists Include EPROSIMA_USER_DLL_EXPORT in Fast DDS CMakeLists Sep 16, 2024
@rsanchez15 rsanchez15 merged commit f1b42f4 into master Sep 16, 2024
14 of 28 checks passed
@rsanchez15 rsanchez15 deleted the bugfix/CMake_DllExport branch September 16, 2024 08:02
@LuciaEchevarria99 LuciaEchevarria99 changed the title Include EPROSIMA_USER_DLL_EXPORT in Fast DDS CMakeLists [21680] Include EPROSIMA_USER_DLL_EXPORT in Fast DDS CMakeLists Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants