Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21745] Add QoS getters from raw XML #5256

Merged
merged 18 commits into from
Oct 9, 2024
Merged

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Sep 24, 2024

Description

This PR extends public API with methods meant to fill QoS structures given a raw XML string containing pertinent profile configurations. For each QoS getter from XML there are three method variants:

  • get_X_qos_from_xml without profile name : the first encountered profile of the expected kind (participant, publisher, etc.) is parsed.
  • get_X_qos_from_xml given profile name : fills the QoS structure with the profile whose name coincides with the one provided.
  • get_default_X_qos_from_xml : fills the structure with the default profile of the expected kind (participant, publisher, etc.) found in the XML string.

This API extension provides backwards compatibility after having made XMLParser private (done in Fast-DDS 3 release).

Merge after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanlofer-eprosima juanlofer-eprosima changed the title Add QoS getters from raw XML [21745] Add QoS getters from raw XML Sep 24, 2024
@juanlofer-eprosima juanlofer-eprosima force-pushed the feature/get-qos-from-xml branch 2 times, most recently from 4ae3aa2 to 4f0b453 Compare September 24, 2024 08:57
@juanlofer-eprosima juanlofer-eprosima force-pushed the feature/get-qos-from-xml branch 2 times, most recently from 4bfe8b3 to 2c61624 Compare October 2, 2024 13:15
@juanlofer-eprosima juanlofer-eprosima marked this pull request as ready for review October 2, 2024 13:30
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 3, 2024 07:50
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 3, 2024
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 3, 2024 08:45
@JesusPoderoso JesusPoderoso added this to the v3.1.0 - Frozen ❄️ milestone Oct 4, 2024
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Header files.

include/fastdds/dds/domain/DomainParticipant.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/domain/DomainParticipant.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/domain/DomainParticipant.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/domain/DomainParticipant.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/domain/DomainParticipant.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/subscriber/Subscriber.hpp Outdated Show resolved Hide resolved
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review. Implementation.

src/cpp/fastdds/domain/DomainParticipantFactory.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/domain/DomainParticipantFactory.cpp Outdated Show resolved Hide resolved
src/cpp/fastdds/domain/DomainParticipantFactory.cpp Outdated Show resolved Hide resolved
src/cpp/xmlparser/XMLProfileManager.h Outdated Show resolved Hide resolved
src/cpp/xmlparser/XMLProfileManager.h Outdated Show resolved Hide resolved
src/cpp/xmlparser/XMLProfileManager.h Outdated Show resolved Hide resolved
Signed-off-by: Juan Lopez Fernandez <[email protected]>
test/utils/FileUtils.hpp Outdated Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@richiware richiware added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 9, 2024
@richiware richiware merged commit 86677ca into master Oct 9, 2024
16 of 17 checks passed
@richiware richiware deleted the feature/get-qos-from-xml branch October 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants