-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21745] Add QoS getters from raw XML #5256
Conversation
37c3e8f
to
6ae5eaf
Compare
4ae3aa2
to
4f0b453
Compare
4bfe8b3
to
2c61624
Compare
2c61624
to
20c0040
Compare
20c0040
to
fb0a418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
fb0a418
to
c5fbb7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. Header files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. Implementation.
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
…rofile requested Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
b524b0b
to
5b14b53
Compare
Signed-off-by: Juan Lopez Fernandez <[email protected]>
5b14b53
to
f6fe520
Compare
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Description
This PR extends public API with methods meant to fill QoS structures given a raw XML string containing pertinent profile configurations. For each QoS getter from XML there are three method variants:
get_X_qos_from_xml
without profile name : the first encountered profile of the expected kind (participant, publisher, etc.) is parsed.get_X_qos_from_xml
given profile name : fills the QoS structure with the profile whose name coincides with the one provided.get_default_X_qos_from_xml
: fills the structure with the default profile of the expected kind (participant, publisher, etc.) found in the XML string.This API extension provides backwards compatibility after having made XMLParser private (done in Fast-DDS 3 release).
Merge after:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist