Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21751] Discard changes with big key-only payload and no key hash #5262

Merged
merged 9 commits into from
Sep 27, 2024
Merged

[21751] Discard changes with big key-only payload and no key hash #5262

merged 9 commits into from
Sep 27, 2024

Commits on Sep 25, 2024

  1. Refs #21707. Regression test. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ae9ca37 View commit details
    Browse the repository at this point in the history

  2. Refs #21707. Test both best_effort and reliable. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2ea6b94 View commit details
    Browse the repository at this point in the history

  3. Refs #21707. Fix by considering offending change as irrelevant. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    12821f7 View commit details
    Browse the repository at this point in the history

  4. Refs #21707. Refactor code in MessageReceiver. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ffccf15 View commit details
    Browse the repository at this point in the history

  5. Refs #21707. Avoid overriding instanceHandle. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2e5ffb0 View commit details
    Browse the repository at this point in the history

  6. Refs #21707. Add TODO so we don't forget to correctly process key-onl… 

    …y payloads in the future.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    73f3586 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Refs #21751. Document and improve code in `change_is_relevant_for_fil… 

    …ter`.

Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    43ae9a6 View commit details
    Browse the repository at this point in the history

  2. Refs #21751. Document else. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    750eaa0 View commit details
    Browse the repository at this point in the history

  3. Refs #21751. Added static assertions for structure sizes. 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    125ea60 View commit details
    Browse the repository at this point in the history