-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21710] DataWriter/Reader get_matched_publication/subscription() Test implementation #5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation_data() test implementation Signed-off-by: Mario Dominguez <[email protected]>
…ription_data() test implementation Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
September 26, 2024 20:36
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…ders_guids() Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/21709/test-impl
branch
from
September 30, 2024 07:44
f357099
to
828275f
Compare
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
September 30, 2024 07:44
…est design Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
September 30, 2024 13:36
Note: |
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 1, 2024 13:41
Merged
13 tasks
richiware
requested changes
Oct 4, 2024
test/mock/rtps/RTPSParticipant/fastdds/rtps/participant/RTPSParticipant.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
Mario-DL
force-pushed
the
feature/21709/test-impl
branch
from
October 7, 2024 08:30
1eeda07
to
e982e89
Compare
Signed-off-by: Mario Dominguez <[email protected]>
…with it and windows complains Signed-off-by: Mario Dominguez <[email protected]>
…or forward declared types Signed-off-by: Mario Dominguez <[email protected]>
richiware
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the test implementation from the test plan:
DDS
DataWriter::get_matched_subscriptions()
DataWriter::get_matched_subscription_data()
DataReader::get_matched_publications()
DataReader::get_matched_publication_data()
RTPS
RTPSParticipant::get_publication_info()
RTPSParticipant::get_subscription_info()
RTPSReader::matched_writers_guids()
(in the implementation PR, this was changed to pure virtual)RTPSWriter:matched_readers_guids()
(in the implementation PR, this was changed to pure virtual)Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist