Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21710] DataWriter/Reader get_matched_publication/subscription() Test implementation #5264

Merged
merged 15 commits into from
Oct 8, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 25, 2024

Description

This PR adds the test implementation from the test plan:

DDS

  • DataWriter::get_matched_subscriptions()
  • DataWriter::get_matched_subscription_data()
  • DataReader::get_matched_publications()
  • DataReader::get_matched_publication_data()

RTPS

  • RTPSParticipant::get_publication_info()
  • RTPSParticipant::get_subscription_info()
  • RTPSReader::matched_writers_guids() (in the implementation PR, this was changed to pure virtual)
  • RTPSWriter:matched_readers_guids() (in the implementation PR, this was changed to pure virtual)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…ation_data() test implementation

Signed-off-by: Mario Dominguez <[email protected]>
…ription_data() test implementation

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Sep 25, 2024
@Mario-DL Mario-DL added this to the v2.14.4 milestone Sep 25, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 25, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima September 26, 2024 20:36
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima September 30, 2024 07:44
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima September 30, 2024 13:36
@Mario-DL
Copy link
Member Author

Mario-DL commented Oct 1, 2024

Note: RTPSWriter/Reader::matched_readers/writers_guids() methods are changed to be pure virtual in the upcoming feature implementation PR

include/fastdds/rtps/participant/RTPSParticipant.h Outdated Show resolved Hide resolved
include/fastdds/rtps/participant/RTPSParticipant.h Outdated Show resolved Hide resolved
include/fastdds/rtps/participant/RTPSParticipant.h Outdated Show resolved Hide resolved
include/fastdds/rtps/participant/RTPSParticipant.h Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDataWriter.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDataWriter.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsDataWriter.cpp Outdated Show resolved Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from richiware and removed request for richiware October 8, 2024 07:24
…or forward declared types

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL requested review from richiware and removed request for richiware October 8, 2024 08:17
@Mario-DL Mario-DL merged commit 9729667 into feature/21709/main Oct 8, 2024
15 checks passed
@Mario-DL Mario-DL deleted the feature/21709/test-impl branch October 8, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants