Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21751] Discard changes with big key-only payload and no key hash (backport #5262) #5275

Open
wants to merge 3 commits into
base: 2.10.x
Choose a base branch
from
Open

[21751] Discard changes with big key-only payload and no key hash (backport #5262) #5275

wants to merge 3 commits into from
+206 −30

Commits on Sep 27, 2024

  1. Discard changes with big key-only payload and no key hash (#5262) 

    * Refs #21707. Regression test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21707. Test both best_effort and reliable.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21707. Fix by considering offending change as irrelevant.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21707. Refactor code in MessageReceiver.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21707. Avoid overriding instanceHandle.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21707. Add TODO so we don't forget to correctly process key-only payloads in the future.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21751. Document and improve code in `change_is_relevant_for_filter`.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21751. Document else.

Signed-off-by: Miguel Company <[email protected]>

* Refs #21751. Added static assertions for structure sizes.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 175add5)

# Conflicts:
#	test/blackbox/common/BlackboxTestsTransportUDP.cpp
    @MiguelCompany @mergify
    MiguelCompany authored and mergify[bot] committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    eb73324 View commit details
    Browse the repository at this point in the history

  2. Fix conflicts 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9bbfb48 View commit details
    Browse the repository at this point in the history

  3. Fix build 

    Signed-off-by: Miguel Company <[email protected]>
    @MiguelCompany
    MiguelCompany committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7650533 View commit details
    Browse the repository at this point in the history