Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21756] Extended Incompatible QoS for Monitor Service Tests implementation #5294

Merged
merged 5 commits into from
Oct 31, 2024
Merged

[21756] Extended Incompatible QoS for Monitor Service Tests implementation #5294

merged 5 commits into from
Oct 31, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 2, 2024 •
edited by MiguelCompany
Loading

Description

This PR brings the test plan implementation for the Extended Incompatible QoS monitor service feature.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Oct 2, 2024
@Mario-DL Mario-DL added this to the v3.2.0 milestone Oct 2, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 2, 2024 14:28
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 2, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima October 2, 2024 16:43
@Mario-DL Mario-DL added needs-review PR that is ready to be reviewed and removed ci-pending PR which CI is running labels Oct 3, 2024
@Mario-DL Mario-DL mentioned this pull request Oct 21, 2024
Open
14 tasks
@MiguelCompany MiguelCompany self-requested a review October 30, 2024 17:24
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 30, 2024
@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Oct 30, 2024
MiguelCompany
MiguelCompany approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green no-test CI

@MiguelCompany MiguelCompany merged commit 93aff12 into feature/21706/main Oct 31, 2024
13 of 14 checks passed
@MiguelCompany MiguelCompany deleted the feature/21706/test-impl branch October 31, 2024 13:55
Mario-DL added a commit that referenced this pull request Nov 5, 2024
@Mario-DL
Extended Incompatible QoS for Monitor Service Tests implementation (#…
d4a2d63 
…5294)

* Refs #21756: Update Monitor Service IDL

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21756: Update Monitor Service Types

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21756: BB Tests

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21756: little bugfix in guids collections

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21756: Make processed msgs count cleaner

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany