Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20421] Added regresion tests for TypeIdentifier comparation #24

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[20421] Added regresion tests for TypeIdentifier comparation #24

wants to merge 11 commits into from

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo changed the base branch from main to feature/xtypes1.3 February 12, 2024 14:00
@adriancampo adriancampo force-pushed the feature/typeidentifier_comparator branch from 51276ce to fab20d4 Compare February 12, 2024 14:01
JLBuenoLopez
JLBuenoLopez suggested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nitpicks

IDL/structures.idl Outdated Show resolved Hide resolved
IDL/structures.idl Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo

IDL/structures.idl Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR needs to wait before being considered for merging.

JLBuenoLopez and others added 4 commits February 15, 2024 15:40
@JLBuenoLopez
Complete test cases (#19)
d4ea264 
* Refs #19906: add test case: structure inheritance with intermediate empty structure

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19906: remove unused header

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19906: extend Annotations.idl test cases

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #19906: fix typo

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20129: minor fixes to pass TypeObject tests

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20129: fix inherited bitset

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20129: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@adriancampo @JLBuenoLopez
Removed float128 type from annotations. (#20)
65f33f9 
Signed-off-by: adriancampo <[email protected]>
@JLBuenoLopez
Add test cases about bounded collections with unbounded elements (#23)
6e8e239 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Test case: scoped structures (#25)
049a2a3 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
richiware and others added 3 commits February 16, 2024 12:12
@richiware
Add future template for pull requests (#27)
7f3fd13 
* Refs #17138. New template for PR

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #17138. Apply suggestion

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
@JLBuenoLopez
Hotfix: IDL typos (#30)
f09e983 
* Refs #20424: complete structure members

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20424: fix union typo

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20424: use correctly wide strings

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20424: add structure using substructures with same name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@richiware
New test case for unions: unions with complex fields [20586] (#29)
ef234fb 
* Refs #19451. Rebase and remove CRLR

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #19451. Add .gitattributes

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #19451. Apply suggestion

Signed-off-by: Ricardo González Moreno <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
@adriancampo adriancampo force-pushed the feature/typeidentifier_comparator branch 2 times, most recently from fa0a545 to da37d6f Compare March 22, 2024 11:05
@adriancampo adriancampo force-pushed the feature/typeidentifier_comparator branch from da37d6f to eb5b513 Compare March 25, 2024 09:23
@adriancampo adriancampo force-pushed the feature/typeidentifier_comparator branch from a4503b3 to 2defa4b Compare March 25, 2024 11:30
@adriancampo adriancampo mentioned this pull request Mar 26, 2024
Open
Base automatically changed from feature/xtypes1.3 to main June 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriancampo @JLBuenoLopez @richiware