Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21733] Add default-less union struct with extra member #38

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Sep 30, 2024

Description

Type used for regression test, in which DynamicData unions fail to be deserialized when no member is selected: eProsima/Fast-DDS#5279

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Any new/modified type has been properly reflected on test/feature/dynamic_types/dds_types_tests tests in a Pull Request.
  • Any new/modified type has been properly updated on test/dds/xtypes tests using update_header_and_create_cases.py script in a Pull Request.
  • N/A For any new IDL file, Fast DDS update_generated_code_from_idl.sh script adding a new line in file_needing_output_dir list in a Pull Request.

Reviewer Checklist

  • N/A The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.

@juanlofer-eprosima juanlofer-eprosima changed the title Add default-less union struct with extra member [21733] Add default-less union struct with extra member Sep 30, 2024
@richiware richiware self-requested a review October 2, 2024 07:23
@richiware richiware merged commit 923dc59 into main Oct 2, 2024
1 check passed
@richiware richiware deleted the hotfix/unions-without-default branch October 2, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants