Skip to content

Commit

Permalink
Fix TSAN CI to use gcc-12 (#116)
Browse files Browse the repository at this point in the history
* Fix TSAN CI to use gcc-12

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

* Remove warning note in tsan job

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

---------

Signed-off-by: Raul Sanchez-Mateos <[email protected]>
  • Loading branch information
rsanchez15 authored Jun 4, 2024
1 parent 4f16869 commit 28dfaaa
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/reusable-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ jobs:
# TSAN

tsan:
# NOTE: there is a known issue in TSAN 20.04 with std::condition_variable::wait_for
# https://github.com/google/sanitizers/issues/1259
# Until this is fixed, we use 20.04 for TSAN work
runs-on: ubuntu-22.04
steps:

Expand All @@ -176,6 +173,11 @@ jobs:

- name: Compile and run tests
uses: eProsima/eProsima-CI/multiplatform/colcon_build_test@v0
env:
# GCC 11.3 (Ubuntu Jammy default) produces several false positives regarding timed synchronization protocols
# These issues were fixed in GCC 12 so we upgrade to that version.
CC: gcc-12
CXX: g++-12
with:
packages_names: ${{ env.cpp_packages_names }}
cmake_args: -DBUILD_TESTS=ON -DTSAN_BUILD=ON
Expand Down

0 comments on commit 28dfaaa

Please sign in to comment.