Corrected breaks when plotting array data #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Bertol <[email protected]>
This prevents memory leaking and makes the code faster. Signed-off-by: Douglas Bertol <[email protected]>
juanlofer-eprosima
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Thank you @dwbertol for contributing to this repository, we greatly value every effort from the community to help us improve.
It turns out we have detected and fixed this issue in parallel at PR #51, but we would prefer to join yours once this review is addressed. If it is not possible for you to apply the requested suggestions, we would be willing to do so. But note that we have no permission as it is, hence another PR would need to be created from a branch other than main at your fork .
Thanks again, and wish you a happy new year!
Signed-off-by: Douglas Bertol <[email protected]>
|
Hello @juanlofer-eprosima. I have made the changes according to the review. Happy new year! |
juanlofer-eprosima
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin breaks due to memory leaking when the dds message has arrays. This is related to the utilization of DynamicData_ptr and asynchronous deletion of data.
This is in some way related to the same problem of eProsima/Fast-DDS#2970
Signed-off-by: Douglas Bertol [email protected]