Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Key topic support #68

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

manuelValch
Copy link

@manuelValch manuelValch commented Nov 5, 2024

This PR add key annotation support for fastdds-visualizer-plugin.

To be done before draft status can be removed:

  • Document future changes in .dev (based on a trial and error branch)
  • Update startup sequence
  • Update data reception

Please note that in order to use documentation, I have rebased this branch on documentation one referenced in this PR: #67

closes #56

In order to try to make a more rationnal implementation of the support
of keyed topics into visualizer code.
Tryied to document the code so that it will be more clear to me what has
to be done.

Signed-off-by: Manuel Valch <[email protected]>
Tried to describe series, and dds object creation so that I might have a
better idea on how to implemented keyed topics and where to move object
creation.

Signed-off-by: Manuel Valch <[email protected]>
If this commit si applied, then data reception sequence will be
documented as it is much easier for me to plan necessary modifications
for keyed topics handling.

Signed-off-by: Manuel Valch <[email protected]>
Updated dev documentation on how I plan to add key topics handling at
startup so that It si more clear for everyone

Signed-off-by: Manuel Valch <[email protected]>
@manuelValch manuelValch marked this pull request as draft November 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Key topics
1 participant