Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20310] Feature: topic keys with non breaking ABI #2

Open
wants to merge 25 commits into
base: vulcanexus
Choose a base branch
from
Open

[20310] Feature: topic keys with non breaking ABI #2

wants to merge 25 commits into from

Commits on Feb 29, 2024

  1. Refs #20156: Initial infraestructure for get_key_type_support() api m… 

    …ethod

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    1140912 View commit details
    Browse the repository at this point in the history

  2. Refs #20156: Return either true or false depending if the msg has keys 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ae41c59 View commit details
    Browse the repository at this point in the history

  3. Refs #20156: Update message_type_support_key_callbacks_t structure 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ba1542b View commit details
    Browse the repository at this point in the history

  4. Refs #20156: Implement rosidl_typesupport_fastrtps_c generator method… 

    …s for supporting keys

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c95f399 View commit details
    Browse the repository at this point in the history

  5. Refs #20156: Implement rosidl_typesupport_fastrtps_cpp generator meth… 

    …ods for supporting keys

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6452b9c View commit details
    Browse the repository at this point in the history

  6. Refs #20310: Define v2 ABI identifier 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7bd1b92 View commit details
    Browse the repository at this point in the history

  7. Refs #20310: Replace get_key_type_support() with a raw pointer to the… 

    … structure

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    955a8ec View commit details
    Browse the repository at this point in the history

  8. Refs #20151: Clean unsued old methods 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4c441b8 View commit details
    Browse the repository at this point in the history

  9. Refs #20151: set _key as suffix in get_serialized and calculate_max_s… 

    …erialized

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    65eb3a4 View commit details
    Browse the repository at this point in the history

  10. Refs #20151: rosidl_typesupport_fastrtps_c: export key methods to be … 

    …called from outside in headers

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    76ce335 View commit details
    Browse the repository at this point in the history

  11. Refs #20151: rosidl_typesupport_fastrtps_c: source file forward decla… 

    …rations

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ecd186e View commit details
    Browse the repository at this point in the history

  12. Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: gener… 

    …ate_members_for_cdr_serialize

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    57cb023 View commit details
    Browse the repository at this point in the history

  13. Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: gener… 

    …ate_members_for_get_serialized_size

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0ad1b5c View commit details
    Browse the repository at this point in the history

  14. Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: gener… 

    …ate_members_for_max_serialized_size

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7c87bf1 View commit details
    Browse the repository at this point in the history

  15. Refs #20151: rosidl_typesupport_fastrtps_c: update suffix in __key_ca… 

    …llback structure

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    bb61339 View commit details
    Browse the repository at this point in the history

  16. Refs #20151: rosidl_typesupport_fastrtps_c: avoid generating cdr_seri… 

    …alize_key and cdr_deserialize_key methods that are not going to be used nor exported if the type do not have keys

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    155e31f View commit details
    Browse the repository at this point in the history

  17. Refs #20151: rosidl_typesupport_fastrtps_cpp: export key methods to b… 

    …e called from outside in headers

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    da232fe View commit details
    Browse the repository at this point in the history

  18. Refs #20151: rosidl_typesupport_fastrtps_cpp: source file forward dec… 

    …larations

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    bdeaa95 View commit details
    Browse the repository at this point in the history

  19. Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: gen… 

    …erate_members_for_cdr_serialize. Also, generate proxy methods only when the type has a key

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    01b1ec1 View commit details
    Browse the repository at this point in the history

  20. Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: gen… 

    …erate_members_for_get_serialized_size adn proxy

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b769e7b View commit details
    Browse the repository at this point in the history

  21. Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: gen… 

    …erate_members_for_max_serialized_size and proxy

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    46208a3 View commit details
    Browse the repository at this point in the history

  22. Refs #20151: rosidl_typesupport_fastrtps_cpp: dummy cdr_deserialize_k… 

    …ey method and proxy

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    09504e8 View commit details
    Browse the repository at this point in the history

  23. Refs #20151: rosidl_typesupport_fastrtps_cpp: update suffix in __key_… 

    …callback structure

Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    af48357 View commit details
    Browse the repository at this point in the history

  24. Refs #20310: Review 2 suggestions on rosidl_typesupport_fastrtps_cpp 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0400104 View commit details
    Browse the repository at this point in the history

  25. Refs #20310: Review 2 suggestions on rosidl_typesupport_fastrtps_c 

    Signed-off-by: Mario Dominguez <[email protected]>
    @Mario-DL
    Mario-DL committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    491fea2 View commit details
    Browse the repository at this point in the history