[20590] Feature: topic keys with non breaking ABI (iron backport) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…s for supporting keys Signed-off-by: Mario Dominguez <[email protected]>
…ods for supporting keys Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
… structure Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
…erialized Signed-off-by: Mario Dominguez <[email protected]>
…called from outside in headers Signed-off-by: Mario Dominguez <[email protected]>
…rations Signed-off-by: Mario Dominguez <[email protected]>
…ate_members_for_cdr_serialize Signed-off-by: Mario Dominguez <[email protected]>
…ate_members_for_get_serialized_size Signed-off-by: Mario Dominguez <[email protected]>
…ate_members_for_max_serialized_size Signed-off-by: Mario Dominguez <[email protected]>
…llback structure Signed-off-by: Mario Dominguez <[email protected]>
…alize_key and cdr_deserialize_key methods that are not going to be used nor exported if the type do not have keys Signed-off-by: Mario Dominguez <[email protected]>
…e called from outside in headers Signed-off-by: Mario Dominguez <[email protected]>
…larations Signed-off-by: Mario Dominguez <[email protected]>
…erate_members_for_cdr_serialize. Also, generate proxy methods only when the type has a key Signed-off-by: Mario Dominguez <[email protected]>
…erate_members_for_get_serialized_size adn proxy Signed-off-by: Mario Dominguez <[email protected]>
…erate_members_for_max_serialized_size and proxy Signed-off-by: Mario Dominguez <[email protected]>
…ey method and proxy Signed-off-by: Mario Dominguez <[email protected]>
…callback structure Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
changed the title
MiguelCompany
requested changes
Mar 5, 2024
rosidl_typesupport_fastrtps_cpp/include/rosidl_typesupport_fastrtps_cpp/message_type_support.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Mario Dominguez <[email protected]>
MiguelCompany
approved these changes
Mar 6, 2024
Mario-DL
added a commit
that referenced
this pull request
Mar 7, 2024
* Refs #20156: Initial infraestructure for get_key_type_support() api method Signed-off-by: Mario Dominguez <[email protected]> * Refs #20156: Return either true or false depending if the msg has keys Signed-off-by: Mario Dominguez <[email protected]> * Refs #20156: Update message_type_support_key_callbacks_t structure Signed-off-by: Mario Dominguez <[email protected]> * Refs #20156: Implement rosidl_typesupport_fastrtps_c generator methods for supporting keys Signed-off-by: Mario Dominguez <[email protected]> * Refs #20156: Implement rosidl_typesupport_fastrtps_cpp generator methods for supporting keys Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Define v2 ABI identifier Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Replace get_key_type_support() with a raw pointer to the structure Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: Clean unsued old methods Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: set _key as suffix in get_serialized and calculate_max_serialized Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: export key methods to be called from outside in headers Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: source file forward declarations Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: generate_members_for_cdr_serialize Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: generate_members_for_get_serialized_size Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: generator refactor: generate_members_for_max_serialized_size Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: update suffix in __key_callback structure Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_c: avoid generating cdr_serialize_key and cdr_deserialize_key methods that are not going to be used nor exported if the type do not have keys Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: export key methods to be called from outside in headers Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: source file forward declarations Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: generate_members_for_cdr_serialize. Also, generate proxy methods only when the type has a key Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: generate_members_for_get_serialized_size adn proxy Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: generator refactor: generate_members_for_max_serialized_size and proxy Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: dummy cdr_deserialize_key method and proxy Signed-off-by: Mario Dominguez <[email protected]> * Refs #20151: rosidl_typesupport_fastrtps_cpp: update suffix in __key_callback structure Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Review 2 suggestions on rosidl_typesupport_fastrtps_cpp Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: Review 2 suggestions on rosidl_typesupport_fastrtps_c Signed-off-by: Mario Dominguez <[email protected]> * Refs #20310: NIT Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from #2 to
vulcanexus-iron