Update the AppBundler plugin to better detect the Java version #2769
Conversation
There was a problem hiding this comment.
Please review and merge evolvedbinary/appbundler-maven-plugin#4, cut another release of the plugin, and update this version to the new release. I've tested the PR and confirmed that it works. Without that, eXist-db.app still won't launch on macOS after under Zulu 8. Sorry, I'd forgotten that this change to the appbundler-maven-plugin would be necessary, even after appbundler itself incorporated my PR (now in TheInfiniteKind/appbundler@8d6140b and TheInfiniteKind/appbundler@f5603fb).
… lead to Travis timeouts if a particuarly slow build produces no long output for 10 minutes or more
adamretter
force-pushed
the
hotfix/appbundler-jdk-detection
branch
from
ed9b219 to
b7fbf2d
Compare
|
@joewiz Done! Thank you :-) |
There was a problem hiding this comment.
Testing this revised PR, I am getting ClassNotFoundException errors when starting eXist-db.app having built it with various JDKs. Details reported to @adamretter in Slack, but the key portion is:
java.lang.ClassNotFoundException: -Djava.library.path=/Users/joe/workspace/exist/exist-distribution/target/exist-distribution-5.0.0-RC8-SNAPSHOT.app/Contents/MacOS
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:436)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:588)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
at org.exist.start.Main.invokeMain(Main.java:107)
at org.exist.start.Main.runEx(Main.java:246)
at org.exist.start.Main.run(Main.java:121)
at org.exist.start.Main.main(Main.java:60)
Until we resolve this, please do not merge.
|
Hi Adam, Sean merged the PR fixing the outstanding issue with appbundler: TheInfiniteKind/appbundler#46. Would you have time to prepare a new release of the maven plugin and update this PR? I’ll also submit an updated version of my 4.x PR. |
|
@joewiz I have now released |
|
@adamretter Thanks! I'll test and prepare a full round of PRs for develop-4.x, develop, and develop-5.0.0. It may take a few days as I'm traveling. |
|
Superseded by #2790. |
No description provided.