Support optional biometrics on iOS platform. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that user's without biometrics enrolled can authenticate using a PIN.
eaceto
reviewed
Oct 29, 2023
There was a problem hiding this comment.
I believe the idea is good, but the implementation is very iOS specific. I think the correct approach will be to define an authentication method type across all implementations. Let me thinks and draft an approach and I will send that PR to you so we can discuss around it.
Thanks very much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that user's without biometrics enrolled can authenticate using a PIN.
Adds the
setBiometricsRequired()iOS specific-method, users can callplugin.setBiometricsRequired(false)to override the default behavior (biometrics required) and support PIN authentication on iOS.