Add a SurfaceWorkErrors() opt to the retrier #51
Merged
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
requested changes
May 7, 2024
|
@eapache Thank you for your review! I believe I addressed all your comments. |
eapache
approved these changes
Jul 19, 2024
|
Thanks! Released in package version 1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the retrier encounters a context-related error, such as
context.DeadlineExceededwhile attempting retries ofwork(), the context error is returned. This means the actual error fromwork()never bubbles up. Because the context is often used to enforce a timeout, many callers are likely more interested in the last non-nil error returned by thework()function.We introduce a
WithSurfaceWorkErrors()option to theretrier.Retrierthat when used, means the last non-nilworkerror will be returned even if context-related errors are encountered.