-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area indicators and country code #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for the most part.
I noticed, the total population number is a bit odd, with the .0288
humans. For can round the number, if feels like this should be done at data ingest.
@oliverroick I made some updates following your feedback, this is ready for another review. The indicators section should look like this: ![]() The changes introduced are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are looking good!
# Conflicts: # src/app/(home)/area/[areaId]/page.tsx
Contributes to: #65, #43, #20
Changes:
npm-run-path
from v5.3.0 to v6.0.0 introduced in chore: Migrate to MapboxGL #62, as it was breaking the ingest scriptmeta
JSON property to theArea
model to store indicators, country codes, and other metadatameta
propertyHow to Test:
global-food-twin-dev-db
Known Issues:
I performed a new ingestion with a reduced number of flows to speed up the process, but unfortunately, most areas don’t have flow data. Here are some example areas that do:
The country codes use 3-letter abbreviations because this is the only format available in the provided data
Screen capture
@oliverroick this is ready for review.
cc @wrynearson @faustoperez