Skip to content

Commit

Permalink
Release 0.1.0-alpha.14 (#615)
Browse files Browse the repository at this point in the history
  • Loading branch information
paraseba authored Jan 23, 2025
1 parent 01ef92f commit 113af16
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 13 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Changelog.python.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog

## Python Icechunk Library 0.1.0a13
## Python Icechunk Library 0.1.0a14

### Features

Expand Down
4 changes: 2 additions & 2 deletions icechunk-python/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "icechunk-python"
version = "0.1.0-alpha.13"
version = "0.1.0-alpha.14"
description = "Transactional storage engine for Zarr designed for use on cloud object storage"
readme = "../README.md"
repository = "https://github.com/earth-mover/icechunk"
Expand All @@ -21,7 +21,7 @@ crate-type = ["cdylib"]
bytes = "1.9.0"
chrono = { version = "0.4.39" }
futures = "0.3.31"
icechunk = { path = "../icechunk", version = "0.1.0-alpha.13" }
icechunk = { path = "../icechunk", version = "0.1.0-alpha.14" }
pyo3 = { version = "0.23", features = [
"chrono",
# do we really need this one?
Expand Down
2 changes: 1 addition & 1 deletion icechunk/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "icechunk"
version = "0.1.0-alpha.13"
version = "0.1.0-alpha.14"
description = "Transactional storage engine for Zarr designed for use on cloud object storage"
readme = "../README.md"
repository = "https://github.com/earth-mover/icechunk"
Expand Down
7 changes: 0 additions & 7 deletions icechunk/src/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1296,35 +1296,28 @@ async fn flush(
}
}

dbg!(&flush_data.manifest_refs);

// Now we need to go through all the new arrays, and generate manifests for them

for (node_path, node_id) in flush_data.change_set.new_arrays() {
flush_data.write_manifest_for_new_node(node_id, node_path).await?;
}

dbg!(&flush_data.manifest_refs);

let all_nodes = updated_nodes(
flush_data.asset_manager,
flush_data.change_set,
flush_data.parent_id,
)
.await?
.map(|node| {
dbg!(&node.path);
let id = &node.id;
// TODO: many clones
if let NodeData::Array(meta, original_manifests) = node.node_data {
if let Some(manifests) = flush_data.manifest_refs.get(id) {
dbg!("found");
NodeSnapshot {
node_data: NodeData::Array(meta.clone(), manifests.clone()),
..node
}
} else {
dbg!("not found");
NodeSnapshot {
node_data: NodeData::Array(meta, original_manifests),
..node
Expand Down

0 comments on commit 113af16

Please sign in to comment.