-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: subgroups in editor sidebar #50
base: main
Are you sure you want to change the base?
POC: subgroups in editor sidebar #50
Conversation
@timoconnellaus is attempting to deploy a commit to the Shopstory Team on Vercel. A member of the Team first needs to authorize it. |
I like it, looks good too. The only question: why not just a separate |
To be honest because there was so much logic deep into the product for the groups. I got a bit lazy and made the superficial change 😂. I will change it to subgroup. |
@r00dY I thought about this a bit more and I thought maybe a more flexible approach would be to allow for an extra field in the SchemaProp called metadata and then allow people to customise groups as they see fit by providing a custom component that is used to render groups This could be implemented using #53 |
I like the approach. Really really like it. There's also #37 that is about customising topbar, I even suggested similar approach. Actually all the UI around canvas (sidebar on the right, potential sidebar on the left, topbar etc) could be totally customisable and just a function of editor state (which also changes when users interact with the canvas). I'll think about it during the weekend but it's a very good approach and probably could be done quickly. |
Adds sub categories in the editor sidebar
Subcategories can be added to the group in the definition with :: notation