Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document pre_run_shell_cmd_hook and post_run_shell_cmd_hook #210

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 31, 2023

No description provided.

@boegel boegel added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 31, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 31, 2023
@boegel boegel requested a review from branfosj August 31, 2023 19:22
@boegel
Copy link
Member Author

boegel commented Sep 1, 2023

markdownlint isn't happy, and I don't understand why, the links to the subsections work fine...

markdownlint-cli2 v0.7.1 (markdownlint v0.28.2)
Finding: **/*.md !docs/demos !docs/version-specific
Linting: 63 file(s)
Summary: 4 error(s)
Error: docs/hooks.md:[12](https://github.com/easybuilders/easybuild-docs/actions/runs/6046813459/job/16409066224?pr=210#step:3:13)8:3 MD051/link-fragments Link fragments should be valid [Context: "[Hook arguments](#hooks-arguments)"] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md051.md
Error: docs/hooks.md:129:3 MD051/link-fragments Link fragments should be valid [Context: "[Return value of hooks](#hooks-return-value)"] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md051.md
Error: docs/hooks.md:[13](https://github.com/easybuilders/easybuild-docs/actions/runs/6046813459/job/16409066224?pr=210#step:3:14)0:3 MD051/link-fragments Link fragments should be valid [Context: "[Parse hook specifics](#parse-hook-specifics)"] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md051.md
Error: docs/hooks.md:277:41 MD051/link-fragments Link fragments should be valid [Context: "[Parse hook specifics](#parse-hook-specifics)"] https://github.com/DavidAnson/markdownlint/blob/v0.28.2/doc/md051.md
Error: Failed with exit code: 1

I'll disable rule MD051 to make it happy...

docs/hooks.md Outdated Show resolved Hide resolved
.markdownlint.yml Outdated Show resolved Hide resolved
@branfosj branfosj merged commit 0f37445 into easybuilders:develop Sep 1, 2023
4 checks passed
@boegel boegel deleted the run_shell_cmd_hook branch September 3, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants