Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/12.2.0] fsm-lite v1.0, sdsl-lite v2.0.3 #20503

Merged

Conversation

verdurin
Copy link
Member

@verdurin verdurin commented May 9, 2024

(created using eb --new-pr)

@verdurin verdurin added the new label May 9, 2024
sanity_check_paths = {
'files': ['bin/fsm-lite'],
'dirs': [],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin is it possible to add a sanity_check_commands item here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors done

@verdurin
Copy link
Member Author

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/2f15829f654a416bfd3fecb2867f6f57 for a full test report.

@verdurin
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20503 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20503 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13953

Test results coming soon (I hope)...

- notification for comment with ID 2249845265 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c07a7535f09799f538c05ecb8ffcbd6d for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.2 milestone Jul 25, 2024
@smoors
Copy link
Contributor

smoors commented Jul 25, 2024

Going in, thanks @verdurin!

@smoors smoors merged commit eb990b9 into easybuilders:develop Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants