-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch to fix implicit function declaration in OpenMPI 4.1.4 #20949
add patch to fix implicit function declaration in OpenMPI 4.1.4 #20949
Conversation
Test report by @Flamefire |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2206788594 processed Message to humans: this is just bookkeeping information for me, |
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2206809892 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)The code in OpenMPI calls
mca_common_cuda_fini
which isn't defined and hence gets implicitly declared which might pick a real function during linking which may or may not work. For recent C standards this implicit declaration is even forbidden which causes an error when compiling with intel-compilers. See the upstream issue open-mpi/ompi#11381Hence also remove it for the existing 4.1.4 ECs using open-mpi/ompi#11382