Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to fix implicit function declaration in OpenMPI 4.1.4 #20949

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 2, 2024

(created using eb --new-pr)

The code in OpenMPI calls mca_common_cuda_fini which isn't defined and hence gets implicitly declared which might pick a real function during linking which may or may not work. For recent C standards this implicit declaration is even forbidden which causes an error when compiling with intel-compilers. See the upstream issue open-mpi/ompi#11381

Hence also remove it for the existing 4.1.4 ECs using open-mpi/ompi#11382

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
n1610 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/cf193e3b3eda13519a99d7223af94612 for a full test report.

@boegel boegel changed the title fix implicit function declaration in OpenMPI 4.1.4 add patch to fix implicit function declaration in OpenMPI 4.1.4 Jul 3, 2024
@boegel boegel added the bug fix label Jul 3, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 3, 2024
@boegel
Copy link
Member

boegel commented Jul 3, 2024

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20949 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20949 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13875

Test results coming soon (I hope)...

- notification for comment with ID 2206788594 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jul 3, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20949 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20949 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4512

Test results coming soon (I hope)...

- notification for comment with ID 2206809892 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6bd6a97e56724830acfcd2856e7972f1 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c3.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/3344ff7a63cd15b8022de3c244337e95 for a full test report.

@boegel
Copy link
Member

boegel commented Jul 3, 2024

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (3 easyconfigs in total)
node3158.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/ed593caacaaf15012ba8e8b0b22167f4 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jul 4, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit 2e5ece9 into easybuilders:develop Jul 4, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240702093530_new_pr_OpenMPI414 branch July 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants