-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio,devel}[GCCcore/13.2.0,foss/2023b] MultiQC v1.22.3, pydantic v2.7.4 #20954
{bio,devel}[GCCcore/13.2.0,foss/2023b] MultiQC v1.22.3, pydantic v2.7.4 #20954
Conversation
Test report by @bedroge |
Test report by @bedroge This can be ignored, it was picking up a broken Python installation in my home directory. I'm redoing this now. |
Test report by @bedroge |
Test report by @verdurin |
@boegelbot please test @ generoso |
@verdurin: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2213792541 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2214072921 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Going in, thanks @bedroge! |
(created using
eb --new-pr
)I had to add another pydantic version for 2023b, as the current one is too old. MultiQC requires >= 2.7.1, see https://github.com/MultiQC/MultiQC/blob/v1.22.3/pyproject.toml#L27. So this probably needs an exception in the CI. Or we have to replace the existing one in other easyconfigs that use it, which are COBRApy and nf-core.