Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio,devel}[GCCcore/13.2.0,foss/2023b] MultiQC v1.22.3, pydantic v2.7.4 #20954

Merged

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 2, 2024

(created using eb --new-pr)

I had to add another pydantic version for 2023b, as the current one is too old. MultiQC requires >= 2.7.1, see https://github.com/MultiQC/MultiQC/blob/v1.22.3/pyproject.toml#L27. So this probably needs an exception in the CI. Or we have to replace the existing one in other easyconfigs that use it, which are COBRApy and nf-core.

@bedroge bedroge added the update label Jul 2, 2024
@bedroge
Copy link
Contributor Author

bedroge commented Jul 2, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/116d3ee2a7f9c1176ff6c69420a5cca9 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 4, 2024

Test report by @bedroge
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen2), Python 3.6.8
See https://gist.github.com/bedroge/d5bd150ae8ca4ce29585675de76d4c66 for a full test report.

This can be ignored, it was picking up a broken Python installation in my home directory. I'm redoing this now.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 4, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen2), Python 3.6.8
See https://gist.github.com/bedroge/c02d20ca1c24386ef05d9bf0fa7792b7 for a full test report.

@verdurin
Copy link
Member

verdurin commented Jul 8, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 11 out of 11 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/4709bcf8a314515c02c6a50ad1284cc3 for a full test report.

@verdurin
Copy link
Member

verdurin commented Jul 8, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20954 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20954 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13903

Test results coming soon (I hope)...

- notification for comment with ID 2213792541 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/60db09970c68cd2c7b179c2d610b6ee2 for a full test report.

@verdurin
Copy link
Member

verdurin commented Jul 8, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20954 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20954 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4537

Test results coming soon (I hope)...

- notification for comment with ID 2214072921 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d770d23c368752b19c77eb483228a547 for a full test report.

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the release after 4.9.2 milestone Jul 9, 2024
@verdurin
Copy link
Member

verdurin commented Jul 9, 2024

Going in, thanks @bedroge!

@verdurin verdurin merged commit d5c9a69 into easybuilders:develop Jul 9, 2024
9 checks passed
@bedroge bedroge deleted the 20240702211653_new_pr_MultiQC1223 branch July 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants