add easyconfig files for openmc software stack #20965
Conversation
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
| ('fmt','9.1.0'), | ||
| ('gsl-lite','0.41.0'), | ||
| ('pugixml','1.12.1'), | ||
| ('xtensor','0.24.7') |
There was a problem hiding this comment.
Try to always include the comma for the last element when having them on multiple lines. E.g. here the mcpl line has changed although it didn't really.
| ('xtensor','0.24.7') | |
| ('xtensor','0.24.7'), |
| @@ -0,0 +1,48 @@ | |||
| diff --unified --recursive --text openmc-0.15.0.orig/CMakeLists.txt openmc-0.15.0.new/CMakeLists.txt | |||
There was a problem hiding this comment.
Is this patch from upstream? If so please include a link (and a description in general)
If not, wouldn't it be easier to just remove the check instead of this large patch (due to aligning existing options) and passing an extra configure flag? If the patch is just for EB the flexibility isn't necessary, is it?
There was a problem hiding this comment.
I suppose you might want the flexibility so it can be left on when using git clone. But I've only run into this for EB so for now I've just simplified the patch and added a description.
This pr introduces a set of easyconfig files for the OpenMC software stack. OpenMC is a monte-carlo particle transport software. It can be configured with or without DAGMC, a geometry engine for running particle transport on CAD models, and thus includes an easyconfig and relevant dependencies for both cases.