Copy build log and artifacts to a permanent location after failures

easybuild/framework/easyblock.py

@@ -75,13 +75,13 @@
 from easybuild.tools.config import FORCE_DOWNLOAD_ALL, FORCE_DOWNLOAD_PATCHES, FORCE_DOWNLOAD_SOURCES
 from easybuild.tools.config import EASYBUILD_SOURCES_URL # noqa
 from easybuild.tools.config import build_option, build_path, get_log_filename, get_repository, get_repositorypath
-from easybuild.tools.config import install_path, log_path, package_path, source_paths
+from easybuild.tools.config import install_path, log_path, package_path, source_paths, error_log_path
 from easybuild.tools.environment import restore_env, sanitize_env
 from easybuild.tools.filetools import CHECKSUM_TYPE_MD5, CHECKSUM_TYPE_SHA256
 from easybuild.tools.filetools import adjust_permissions, apply_patch, back_up_file, change_dir, check_lock
-from easybuild.tools.filetools import compute_checksum, convert_name, copy_file, create_lock, create_patch_info
+from easybuild.tools.filetools import convert_name, copy_file, copy_dir, create_lock, create_patch_info, is_readable
 from easybuild.tools.filetools import derive_alt_pypi_url, diff_files, dir_contains_files, download_file
-from easybuild.tools.filetools import encode_class_name, extract_file
+from easybuild.tools.filetools import encode_class_name, extract_file, compute_checksum
 from easybuild.tools.filetools import find_backup_name_candidate, get_source_tarball_from_git, is_alt_pypi_url
 from easybuild.tools.filetools import is_binary, is_sha256_checksum, mkdir, move_file, move_logs, read_file, remove_dir
 from easybuild.tools.filetools import remove_file, remove_lock, verify_checksum, weld_paths, write_file, symlink
@@ -1045,16 +1045,23 @@ def moduleGenerator(self):
     #
     # DIRECTORY UTILITY FUNCTIONS
     #
-    def gen_builddir(self):
-        """Generate the (unique) name for the builddir"""
+    def get_relative_builddir_base_path(self):
+        """Generate builddir base name relative to build_path"""
         clean_name = remove_unwanted_chars(self.name)
 
         # if a toolchain version starts with a -, remove the - so prevent a -- in the path name
         tc = self.cfg['toolchain']
         tcversion = tc['version'].lstrip('-')
         lastdir = "%s%s-%s%s" % (self.cfg['versionprefix'], tc['name'], tcversion, self.cfg['versionsuffix'])
 
-        builddir = os.path.join(os.path.abspath(build_path()), clean_name, self.version, lastdir)
+        relative_builddir = os.path.join(clean_name, self.version, lastdir)
+
+        return relative_builddir
+
+    def gen_builddir(self):
+        """Generate the (unique) name for the builddir"""
+        relative_builddir = self.get_relative_builddir_base_path()
+        builddir = os.path.join(os.path.abspath(build_path()), relative_builddir)
 
         # make sure build dir is unique if cleanupoldbuild is False or not set
         if not self.cfg.get('cleanupoldbuild', False):
@@ -4198,6 +4205,40 @@ def print_dry_run_note(loc, silent=True):
     dry_run_msg(msg, silent=silent)
 
 
+def persists_failed_compilation_log_and_artifacts(build_successful, application_log, silent, app, err_log_path):
+    def do_if_paths_distinct(operation, source, destination):
+        if not os.path.exists(source):
+            return
+        if os.path.realpath(source) == os.path.realpath(destination):
+            return
+        operation(source, destination)
+
+    if application_log:
+        # there may be multiple log files, or the file name may be different due to zipping
+        logs = glob.glob('%s*' % application_log)
+        print_msg(
+            "Results of the build can be found in the temporary log file(s) %s" % ', '.join(logs),
+            log=_log,
+            silent=silent
+        )
+
+        if err_log_path and not build_successful:
+            for log_file in logs:
+                target_file = os.path.join(err_log_path, os.path.basename(log_file))
+                do_if_paths_distinct(copy_file, log_file, target_file)
+
+            builddir = app.builddir
+            if is_readable(builddir):
+                build_artifact_log_path = os.path.join(err_log_path, app.get_relative_builddir_base_path())
+                do_if_paths_distinct(copy_dir, builddir, build_artifact_log_path)
+
+            print_msg(
+                "Build log and any output artifacts copied to permanent storage: %s" % err_log_path,
+                log=_log,
+                silent=silent
+            )
+
+
 def build_and_install_one(ecdict, init_env):
     """
     Build the software
@@ -4456,10 +4497,8 @@ def ensure_writable_log_dir(log_dir):
         else:
             dry_run_msg("(no ignored errors during dry run)\n", silent=silent)
 
-    if application_log:
-        # there may be multiple log files, or the file name may be different due to zipping
-        logs = glob.glob('%s*' % application_log)
-        print_msg("Results of the build can be found in the log file(s) %s" % ', '.join(logs), log=_log, silent=silent)
+    err_log_path = error_log_path(ec=ecdict['ec'])
+    persists_failed_compilation_log_and_artifacts(success, application_log, silent, app, err_log_path)
 
     del app
 

easybuild/tools/config.py

@@ -106,6 +106,7 @@
 DEFAULT_PATH_SUBDIRS = {
     'buildpath': 'build',
     'containerpath': 'containers',
+    'errorlogpath': 'error_log',
     'installpath': '',
     'packagepath': 'packages',
     'repositorypath': 'ebfiles_repo',
@@ -478,6 +479,7 @@ class ConfigurationVariables(BaseConfigurationVariables):
         'buildpath',
         'config',
         'containerpath',
+        'errorlogpath',
         'installpath',
         'installpath_modules',
         'installpath_software',
@@ -843,6 +845,33 @@ def log_path(ec=None):
     return log_file_format(return_directory=True, ec=ec, date=date, timestamp=timestamp)
 
 
+def error_log_path(ec=None):
+    """
+    Return the default error log path
+
+    This is a path where file from the build_log_path can be stored permanently
+    :param ec: dict-like value that provides values for %(name)s and %(version)s template values
+    """
+    error_log_path = ConfigurationVariables()['errorlogpath']
+
+    if ec is None:
+        ec = {}
+
+    name, version = ec.get('name', '%(name)s'), ec.get('version', '%(version)s')
+    date = time.strftime("%Y%m%d")
+    timestamp = time.strftime("%H%M%S")
+
+    base_path = '/'.join([error_log_path, name + '-' + version, date + '-' + timestamp])
+
+    path = base_path
+    inc_no = 1
+    while os.path.exists(path):
+        path = base_path + '_' + str(inc_no)
+        inc_no += 1
+
+    return path
+
+
 def get_build_log_path():
     """
     Return (temporary) directory for build log

easybuild/tools/options.py

@@ -571,6 +571,8 @@ def config_options(self):
             'envvars-user-modules': ("List of environment variables that hold the base paths for which user-specific "
                                      "modules will be installed relative to", 'strlist', 'store',
                                      [DEFAULT_ENVVAR_USERS_MODULES]),
+            'errorlogpath': ("Location where logs and artifacts are copied in case of an error",
+                             None, 'store', mk_full_default_path('errorlogpath')),
             'external-modules-metadata': ("List of (glob patterns for) paths to files specifying metadata "
                                           "for external modules (INI format)", 'strlist', 'store', None),
             'hooks': ("Location of Python module with hook implementations", 'str', 'store', None),
@@ -1153,7 +1155,7 @@ def _postprocess_config(self):
         # - the <path> could also specify the location of a *remote* (Git( repository,
         #   which can be done in variety of formats (git@<url>:<org>/<repo>), https://<url>, etc.)
         #   (see also https://github.com/easybuilders/easybuild-framework/issues/3892);
-        path_opt_names = ['buildpath', 'containerpath', 'git_working_dirs_path', 'installpath',
+        path_opt_names = ['buildpath', 'containerpath', 'errorlogpath', 'git_working_dirs_path', 'installpath',
                           'installpath_modules', 'installpath_software', 'prefix', 'packagepath',
                           'robot_paths', 'sourcepath']
 
@@ -1163,8 +1165,8 @@ def _postprocess_config(self):
         if self.options.prefix is not None:
             # prefix applies to all paths, and repository has to be reinitialised to take new repositorypath in account
             # in the legacy-style configuration, repository is initialised in configuration file itself
-            path_opts = ['buildpath', 'containerpath', 'installpath', 'packagepath', 'repository', 'repositorypath',
-                         'sourcepath']
+            path_opts = ['buildpath', 'containerpath', 'errorlogpath', 'installpath', 'packagepath', 'repository',
+                         'repositorypath', 'sourcepath']
             for dest in path_opts:
                 if not self.options._action_taken.get(dest, False):
                     if dest == 'repository':

test/framework/easyconfigs/test_ecs/t/toy/toy-0.0-buggy.eb

@@ -0,0 +1,33 @@
+name = 'toy'
+version = '0.0'
+versionsuffix = '-buggy'
+
+homepage = 'https://easybuilders.github.io/easybuild'
+description = "Toy C program, 100% toy."
+
+toolchain = SYSTEM
+
+sources = [SOURCE_TAR_GZ]
+checksums = [[
+    'be662daa971a640e40be5c804d9d7d10',  # default (MD5)
+    '44332000aa33b99ad1e00cbd1a7da769220d74647060a10e807b916d73ea27bc',  # default (SHA256)
+    ('adler32', '0x998410035'),
+    ('crc32', '0x1553842328'),
+    ('md5', 'be662daa971a640e40be5c804d9d7d10'),
+    ('sha1', 'f618096c52244539d0e89867405f573fdb0b55b0'),
+    ('size', 273),
+]]
+patches = [
+    'toy-0.0_add-bug.patch',
+    ('toy-extra.txt', 'toy-0.0'),
+]
+
+sanity_check_paths = {
+    'files': [('bin/yot', 'bin/toy')],
+    'dirs': ['bin'],
+}
+
+postinstallcmds = ["echo TOY > %(installdir)s/README"]
+
+moduleclass = 'tools'
+# trailing comment, leave this here, it may trigger bugs with extract_comments()

test/framework/easyconfigs/test_ecs/t/toy/toy-0.0-test.eb

@@ -18,7 +18,7 @@ checksums = [[
     ('size', 273),
 ]]
 patches = [
-    'toy-0.0_fix-silly-typo-in-printf-statement.patch',
+    'toy-0.0_add-bug.patch',
     ('toy-extra.txt', 'toy-0.0'),
 ]
 

test/framework/options.py

@@ -5283,7 +5283,15 @@ def test_prefix_option(self):
 
         regex = re.compile(r"(?P<cfg_opt>\S*).*%s.*" % self.test_prefix, re.M)
 
-        expected = ['buildpath', 'containerpath', 'installpath', 'packagepath', 'prefix', 'repositorypath']
+        expected = [
+            'buildpath',
+            'containerpath',
+            'errorlogpath',
+            'installpath',
+            'packagepath',
+            'prefix',
+            'repositorypath',
+        ]
         self.assertEqual(sorted(regex.findall(txt)), expected)
 
     def test_dump_env_script(self):

test/framework/sandbox/sources/toy/toy-0.0_add-bug.patch

@@ -0,0 +1,10 @@
+--- a/toy-0.0.orig/toy.source	2014-03-06 18:48:16.000000000 +0100
++++ b/toy-0.0/toy.source	2020-08-18 12:19:35.000000000 +0200
+@@ -2,6 +2,6 @@
+
+ int main(int argc, char* argv[]){
+
+-    printf("I'm a toy, and proud of it.\n");
++    printf("I'm a toy, and proud of it.\n")
+     return 0;
+ }

test/framework/toy_build.py

@@ -40,8 +40,10 @@
 import sys
 import tempfile
 import textwrap
+import pathlib
+import filecmp
 from easybuild.tools import LooseVersion
-from test.framework.utilities import EnhancedTestCase, TestLoaderFiltered
+from test.framework.utilities import EnhancedTestCase, TestLoaderFiltered, TempDirectory
 from test.framework.package import mock_fpm
 from unittest import TextTestRunner
 
@@ -156,9 +158,9 @@ def check_toy(self, installpath, outtxt, name='toy', version='0.0', versionprefi
         devel_module_path = os.path.join(software_path, 'easybuild', '%s-%s-easybuild-devel' % (name, full_version))
         self.assertExists(devel_module_path)
 
-    def test_toy_build(self, extra_args=None, ec_file=None, tmpdir=None, verify=True, fails=False, verbose=True,
-                       raise_error=False, test_report=None, name='toy', versionsuffix='', testing=True,
-                       raise_systemexit=False, force=True, test_report_regexs=None, debug=True):
+    def test_toy_build(self, extra_args=None, ec_file=None, tmpdir=None, tmp_logdir=None, verify=True, fails=False,
+                       verbose=True, raise_error=False, test_report=None, name='toy', versionsuffix='', testing=True,
+                       raise_systemexit=False, force=True, test_report_regexs=None, debug=True, check_errorlog=None):
         """Perform a toy build."""
         if extra_args is None:
             extra_args = []
@@ -172,6 +174,7 @@ def test_toy_build(self, extra_args=None, ec_file=None, tmpdir=None, verify=True
             '--sourcepath=%s' % self.test_sourcepath,
             '--buildpath=%s' % self.test_buildpath,
             '--installpath=%s' % self.test_installpath,
+            '--errorlogpath=%s' % self.test_errorlogpath,
             '--unittest-file=%s' % self.logfile,
             '--robot=%s' % os.pathsep.join([self.test_buildpath, os.path.dirname(__file__)]),
         ]
@@ -183,6 +186,8 @@ def test_toy_build(self, extra_args=None, ec_file=None, tmpdir=None, verify=True
             args.append('--tmpdir=%s' % tmpdir)
         if test_report is not None:
             args.append('--dump-test-report=%s' % test_report)
+        if tmp_logdir is not None:
+            args.append('--tmp-logdir=%s' % tmp_logdir)
         args.extend(extra_args)
         myerr = None
         try:
@@ -228,6 +233,9 @@ def test_toy_build(self, extra_args=None, ec_file=None, tmpdir=None, verify=True
                 msg = "Pattern %s found in full test report: %s" % (regex.pattern, test_report_txt)
                 self.assertTrue(regex.search(test_report_txt), msg)
 
+        if check_errorlog is not None:
+            check_errorlog(outtxt, tmp_logdir, self.test_buildpath, self.test_errorlogpath)
+
         return outtxt
 
     def run_test_toy_build_with_output(self, *args, **kwargs):
@@ -271,6 +279,56 @@ def test_toy_broken(self):
         # cleanup
         shutil.rmtree(tmpdir)
 
+    def assert_build_files_copied(self, buildpath, errorlogpath):
+        buildir = pathlib.Path(buildpath)
+        errorlogdir = pathlib.Path(errorlogpath)
+        iso_date_pattern = r'????????-??????'
+        for file in buildir.iterdir():
+            file_relative_path = file.relative_to(buildir)
+            file_copies = list(errorlogdir.glob(f"toy-0.0/{iso_date_pattern}/{file_relative_path}"))
+            self.assertTrue(len(file_copies) == 1, f"Unique copy of toy build file '{file}' made")
+            for file_copy in file_copies:
+                if file_copy.is_file():
+                    msg = f"File '{file}' copied succesfully"
+                    self.assertTrue(filecmp.cmp(str(file), str(file_copy), shallow=False), msg)
+
+    def assert_log_files_copied(self, tmp_logpath, errorlogpath):
+        for log_file in pathlib.Path(tmp_logpath).glob("**/*.log"):
+            file_name = log_file.name
+            saved_log_files = list(pathlib.Path(errorlogpath).glob(f"**/{file_name}"))
+            self.assertTrue(len(saved_log_files) == 1, f"Unique copy of log file '{log_file}' made")
+            for saved_log_file in saved_log_files:
+                msg = f"Log file '{log_file}' copied succesfully"
+                self.assertTrue(filecmp.cmp(str(log_file), str(saved_log_file), shallow=False), msg)
+
+    def assert_error_reported(self, outtxt, output_regexs):
+        for regex_pattern in output_regexs:
+            regex = re.compile(regex_pattern, re.M)
+            msg = "Pattern %s found in full test report: %s" % (regex.pattern, outtxt)
+            self.assertTrue(regex.search(outtxt), msg)
+
+    def check_errorlog(self, outtxt, output_regexs, tmp_logpath, buildpath, errorlogpath):
+        self.assert_build_files_copied(buildpath, errorlogpath)
+        self.assert_log_files_copied(tmp_logpath, errorlogpath)
+        self.assert_error_reported(outtxt, output_regexs)
+
+    def test_toy_broken_compilation(self):
+        """Test whether log files and compilafor broken compilations are copied to a permanent location"""
+        tmpdir = TempDirectory()
+        tmp_logdir = TempDirectory()
+        broken_compilation_ec = os.path.join(os.path.dirname(__file__),
+                                             'easyconfigs', 'test_ecs', 't', 'toy', 'toy-0.0-buggy.eb')
+
+        output_regexs = [r'^\s+toy\.c:5:44: error: expected ;']
+
+        def check_errorlog(outtxt, tmp_logpath, buildpath, errorlogpath):
+            self.check_errorlog(outtxt, output_regexs, tmp_logpath, buildpath, errorlogpath)
+
+        self.run_test_toy_build_with_output(
+            ec_file=broken_compilation_ec, tmpdir=tmpdir.get_path(), tmp_logdir=tmp_logdir.get_path(),
+            verify=False, fails=True, verbose=False, raise_error=False,
+            name='toy', versionsuffix='-buggy', check_errorlog=check_errorlog)
+
     def test_toy_tweaked(self):
         """Test toy build with tweaked easyconfig, for testing extra easyconfig parameters."""
         test_ecs_dir = os.path.join(os.path.abspath(os.path.dirname(__file__)), 'easyconfigs')

test/framework/utilities.py

@@ -121,6 +121,8 @@ def setUp(self):
         os.environ['EASYBUILD_BUILDPATH'] = self.test_buildpath
         self.test_installpath = tempfile.mkdtemp()
         os.environ['EASYBUILD_INSTALLPATH'] = self.test_installpath
+        self.test_errorlogpath = tempfile.mkdtemp()
+        os.environ['EASYBUILD_ERRORLOGPATH'] = self.test_errorlogpath
 
         # make sure that the tests only pick up easyconfigs provided with the tests
         os.environ['EASYBUILD_ROBOT_PATHS'] = os.path.join(testdir, 'easyconfigs', 'test_ecs')
@@ -514,3 +516,15 @@ def find_full_path(base_path, trim=(lambda x: x)):
             break
 
     return full_path
+
+
+class TempDirectory:
+    def __init__(self):
+        self.dir = tempfile.mkdtemp()
+
+    def __del__(self):
+        if os.path.exists(self.dir):
+            shutil.rmtree(self.dir)
+
+    def get_path(self):
+        return self.dir