use enumerate where applicable fixing _generate_multi_deps_list
#4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multi-dep module loaded by default is the first entry in `self-cfg-multi_deps` for each name. Using the version order from the easyconfig could lead to inconsistencies between description and behavior.
In some places we require the index and value of a list and using `range(len(...))` is not optimal for that. Using `enumerate` yields the value together with the index making the intention clearer (and the code likely faster).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyLint found uses of
range(len(...))where the index was then used to access an element.Using
enumerateyields the value together with the index making the intention clearer (and the code likely faster).This also led to a nice simplification possibility in make_module_dep, get_parsed_multi_deps and configobj.walk and a possible bugfix in _generate_multi_deps_list:
The code generating the load statement uses the first module of each name in
self.app.cfg.multi_depsbut the code generating the help text has an additional version check. We don't need that and it can possibly be wrong if the order of the versions was different somehow.I simply collect all modules with the given name using a (fast) list comprehension and mark the first as the default