Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deprecated behaviour when running test_fetch_sources_git with Python < 3.9 #4733

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

branfosj
Copy link
Member

From https://github.com/easybuilders/easybuild-framework/actions/runs/12544709924/job/34977742103

======================================================================
ERROR: test_fetch_sources_git (test.framework.easyblock.EasyBlockTest)
Test fetch_sources method from git repo.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/test/framework/easyblock.py", line 1718, in test_fetch_sources_git
    eb.fetch_sources(sources, checksums=checksums)
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/easybuild/framework/easyblock.py", line 511, in fetch_sources
    checksum = self.get_checksum_for(checksums=checksums, filename=source, index=index)
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/easybuild/framework/easyblock.py", line 387, in get_checksum_for
    '6.0'
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/easybuild/tools/build_log.py", line 215, in deprecated
    fancylogger.FancyLogger.deprecated(self, msg, str(CURRENT_VERSION), ver, *args, **kwargs)
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/easybuild/base/fancylogger.py", line 346, in deprecated
    self.raiseException("DEPRECATED (since v%s) functionality used: %s" % (max_ver, msg), exception=exception)
  File "/tmp/runner/e361bb6a84c200b516a56bf3a0355d38d85acace/lib/python3.7/site-packages/easybuild/base/fancylogger.py", line 330, in raiseException
    raise exception(message).with_traceback(tb)
easybuild.tools.build_log.EasyBuildError: 'DEPRECATED (since v6.0) functionality used: Reproducible tarballs of Git repos are only possible when using Python 3.9+ to run EasyBuild. Skipping checksum verification of testrepository.tar.xz since Python < 3.9 is used.; see https://docs.easybuild.io/deprecated-functionality/ for more information'

@branfosj branfosj added this to the 5.0 milestone Dec 30, 2024
Micket
Micket previously approved these changes Dec 30, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Dec 30, 2024

Alternatively, we should run the test while allowing deprecated functionality?

@branfosj
Copy link
Member Author

Alternatively, we should run the test while allowing deprecated functionality?

I've relooked at the test and I'll fix it to test both the deprecated and standard workflow.

@branfosj branfosj changed the title skip test_fetch_sources_git when running on Python < 3.9 allow deprecated behaviour when running test_fetch_sources_git with Python < 3.9 Dec 30, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel enabled auto-merge December 30, 2024 10:46
@boegel boegel merged commit 52d3f9e into easybuilders:5.0.x Dec 30, 2024
39 checks passed
@branfosj branfosj deleted the skip-test_fetch_sources_git branch December 30, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants